-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18n internationalization in server, fix details and add es translation #142
Conversation
…ternationalization
…ebpush into i18n_internationalization
@skorokithakis could you check this pull request? |
Oh sorry, yes, I was intimidated by the sheer size of this. If you could split it up, that would be great. |
Ok @skorokithakis, I'll split it and resend it in different pull requests. Thanks for the response |
@skorokithakis I created 5 pull requests with the parts of this pull request
Thank you for maintaining the module and that repository. |
Thank you, but you've created them against your own repository, which means I can't merge them here. |
@skorokithakis All pull requests are independent, you can merge one by one (or merge one and not another). Only the translation pull request (#148 and #149) use the code from #147, but they don't have a conflict or problem regarding the merge order. |
Wait a minute, this isn't one of my repos! Wow, how did I get involved here? |
@skorokithakis I don't know hahaha. It's the official repository of https://pypi.org/project/django-webpush/ @safwanrahman Do you maintain this repository? |
@FedeG Thanks for breaking it up. Yes, I am still maintaining this repo. |
@safwanrahman Perfect, I'll be waiting for any news. Thank you |
@FedeG I have merged some of the PR. Can you rebase your other PR and force push it again? |
@safwanrahman Yes, I'm updating all the pull requests |
@safwanrahman I updated all pull requests. Currently, there is only one pending pull request (#149) |
Changes
Readme.md
):urls.py
examples.gitignore
file for django/python package