Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n internationalization in server, fix details and add es translation #142

Closed
wants to merge 14 commits into from

Conversation

FedeG
Copy link
Contributor

@FedeG FedeG commented Sep 2, 2024

Changes

  • Update documentation (Readme.md):
    • Add internationalization documentation to update translation
    • Add internationalization documentation to create new translation language
    • Add documentation of django >= 2.0 on urls.py examples
  • Add i18n internationalization to server strings
    • Add verbose_name to all model fields
    • Add Meta class to models with single and plural name
    • Add labels to forms fields
    • Translate choices value on form
  • Add string representations to all models
  • Add translations to admin actions
  • Add .gitignore file for django/python package
  • Update en translations
  • Create es translations
  • Clean code and remove unused imports

@FedeG FedeG changed the title I18n internationalization and details I18n internationalization in server, fix details and add es translation Sep 2, 2024
@FedeG
Copy link
Contributor Author

FedeG commented Nov 28, 2024

@skorokithakis could you check this pull request?
If you prefer that I divide it in partial pull request, tell me and I will rework it.

@skorokithakis
Copy link
Contributor

Oh sorry, yes, I was intimidated by the sheer size of this. If you could split it up, that would be great.

@FedeG
Copy link
Contributor Author

FedeG commented Jan 12, 2025

Ok @skorokithakis, I'll split it and resend it in different pull requests.

Thanks for the response

@FedeG
Copy link
Contributor Author

FedeG commented Jan 13, 2025

@skorokithakis
Copy link
Contributor

Thank you, but you've created them against your own repository, which means I can't merge them here.

@FedeG
Copy link
Contributor Author

FedeG commented Jan 13, 2025

@skorokithakis All pull requests are independent, you can merge one by one (or merge one and not another).

Only the translation pull request (#148 and #149) use the code from #147, but they don't have a conflict or problem regarding the merge order.

@skorokithakis
Copy link
Contributor

Wait a minute, this isn't one of my repos! Wow, how did I get involved here?

@FedeG
Copy link
Contributor Author

FedeG commented Jan 13, 2025

@skorokithakis I don't know hahaha.
You responded to my pull request, and I understood you are a maintainer.

It's the official repository of https://pypi.org/project/django-webpush/

@safwanrahman Do you maintain this repository?

@safwanrahman
Copy link
Owner

@FedeG Thanks for breaking it up. Yes, I am still maintaining this repo.

@FedeG
Copy link
Contributor Author

FedeG commented Jan 13, 2025

@safwanrahman Perfect, I'll be waiting for any news. Thank you

@safwanrahman
Copy link
Owner

@FedeG I have merged some of the PR. Can you rebase your other PR and force push it again?

@FedeG
Copy link
Contributor Author

FedeG commented Jan 13, 2025

@safwanrahman Yes, I'm updating all the pull requests

@FedeG
Copy link
Contributor Author

FedeG commented Jan 13, 2025

@safwanrahman I updated all pull requests. Currently, there is only one pending pull request (#149)

@FedeG FedeG deleted the i18n_internationalization branch January 13, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants