librbd: check return value during snap_unprotect

This would only fail if the header object was corrupted, so it's unlikely to occur in practice. Signed-off-by: Josh Durgin <[email protected]>
sahid · May 6, 2014 · 6ec99f7 · 6ec99f7
1 parent 6f2edda
commit 6ec99f7
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/librbd/internal.cc b/src/librbd/internal.cc
@@ -664,6 +664,11 @@ namespace librbd {
 					  ictx->header_oid,
 					  snap_id,
 					  RBD_PROTECTION_STATUS_UNPROTECTED);
+    if (r < 0) {
+      lderr(ictx->cct) << "snap_unprotect: error setting unprotected status"
+		       << dendl;
+      goto reprotect_and_return_err;
+    }
     notify_change(ictx->md_ctx, ictx->header_oid, NULL, ictx);
     return 0;