osd: fix session leak when waiting on map

We don't want to leak the Session if this Session is already waiting on a map. Introduced by eb30f88. Signed-off-by: Sage Weil <[email protected]>
sahid · Jul 7, 2014 · aefbac5 · aefbac5
1 parent 17ad083
commit aefbac5
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/osd/OSD.h b/src/osd/OSD.h
@@ -1166,8 +1166,10 @@ class OSD : public Dispatcher,
   }
   void register_session_waiting_on_map(Session *session) {
     Mutex::Locker l(session_waiting_for_map_lock);
-    session->get();
-    session_waiting_for_map.insert(session);
+    if (session_waiting_for_map.count(session) == 0) {
+      session->get();
+      session_waiting_for_map.insert(session);
+    }
   }
   void clear_session_waiting_on_map(Session *session) {
     Mutex::Locker l(session_waiting_for_map_lock);