Skip to content

Commit

Permalink
Rename didUpdateCurrentRangeMode to preserveCurrentRangeMode
Browse files Browse the repository at this point in the history
  • Loading branch information
garrettmoon committed Nov 28, 2016
1 parent 62f378a commit 04dc582
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions AsyncDisplayKit/Details/ASRangeController.mm
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ @interface ASRangeController ()
BOOL _layoutControllerImplementsSetViewportSize;
NSSet<NSIndexPath *> *_allPreviousIndexPaths;
ASLayoutRangeMode _currentRangeMode;
BOOL _didUpdateCurrentRange;
BOOL _preserveCurrentRangeMode;
BOOL _didRegisterForNodeDisplayNotifications;
CFTimeInterval _pendingDisplayNodesTimestamp;

Expand All @@ -62,7 +62,7 @@ - (instancetype)init

_rangeIsValid = YES;
_currentRangeMode = ASLayoutRangeModeInvalid;
_didUpdateCurrentRange = NO;
_preserveCurrentRangeMode = NO;

[[[self class] allRangeControllersWeakSet] addObject:self];

Expand Down Expand Up @@ -144,15 +144,11 @@ - (void)updateIfNeeded

- (void)updateCurrentRangeWithMode:(ASLayoutRangeMode)rangeMode
{
_preserveCurrentRangeMode = YES;
if (_currentRangeMode != rangeMode) {
_currentRangeMode = rangeMode;
_didUpdateCurrentRange = YES;

[self setNeedsUpdate];
} else if (_needsRangeUpdate) {
// If _needsRangeUpdate is YES, but we don't set didUpdateCurrentRange, it
// will be overridden.
_didUpdateCurrentRange = YES;
}
}

Expand Down Expand Up @@ -224,7 +220,7 @@ - (void)_updateVisibleNodeIndexPaths
ASLayoutRangeMode rangeMode = _currentRangeMode;
// If the range mode is explicitly set via updateCurrentRangeWithMode: it will last in that mode until the
// range controller becomes visible again or explicitly changes the range mode again
if ((!_didUpdateCurrentRange && ASInterfaceStateIncludesVisible(selfInterfaceState)) || [[self class] isFirstRangeUpdateForRangeMode:rangeMode]) {
if ((!_preserveCurrentRangeMode && ASInterfaceStateIncludesVisible(selfInterfaceState)) || [[self class] isFirstRangeUpdateForRangeMode:rangeMode]) {
rangeMode = [ASRangeController rangeModeForInterfaceState:selfInterfaceState currentRangeMode:_currentRangeMode];
}

Expand Down Expand Up @@ -267,7 +263,7 @@ - (void)_updateVisibleNodeIndexPaths
_allPreviousIndexPaths = allCurrentIndexPaths;

_currentRangeMode = rangeMode;
_didUpdateCurrentRange = NO;
_preserveCurrentRangeMode = NO;

if (!_rangeIsValid) {
[allIndexPaths addObjectsFromArray:ASIndexPathsForTwoDimensionalArray(allNodes)];
Expand Down Expand Up @@ -592,7 +588,7 @@ + (void)willEnterForeground:(NSNotification *)notification
for (ASRangeController *rangeController in allRangeControllers) {
BOOL isVisible = ASInterfaceStateIncludesVisible([rangeController interfaceState]);
[rangeController updateCurrentRangeWithMode:isVisible ? ASLayoutRangeModeMinimum : ASLayoutRangeModeVisibleOnly];
[rangeController setNeedsUpdate];
// There's no need to call needs update as updateCurrentRangeWithMode sets this if necessary.
[rangeController updateIfNeeded];
}

Expand Down

0 comments on commit 04dc582

Please sign in to comment.