New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix severe error for Haitian-Creole declension #62

Merged

yoikawa merged 1 commit into main from fix-dictionary

Sep 17, 2024

Contributor

yoikawa commented Sep 17, 2024

Fixed corner case If French noun has no singular form, Haitian-Creole derives no value and ends up returning null that may throw an exception


          fix severe error for Haitian-Creole declention

df5765e

yoikawa commented

View reviewed changes

src/main/java/com/force/i18n/grammar/impl/SimpleDeclension.java

-                              logger.severe("###\tError: The noun " + name + " has no value");
+                              // this is wrong. the noun should have singular form
+                              HumanLanguage language = this.getDeclension().getLanguage();
+                              logger.severe(() -> "###\tError: " + language.getLocaleString() + "The noun " + name + " has no value");

Contributor Author

yoikawa Sep 17, 2024

show language information for SEVERE error. also, refactor using Logger#severe(Supplier<String>) to construct log message lazily.

ytanida approved these changes

View reviewed changes

yoikawa merged commit 91a742b into main

4 checks passed

yoikawa deleted the fix-dictionary branch

September 17, 2024 05:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet