Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default version is very old and not available in repos anymore. #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bogdanr
Copy link

@bogdanr bogdanr commented Oct 19, 2021

The default version of packages is very old and not available in repos anymore. We bump it up to the latest so the formula works out of the box.

…e bump it up to the latest so the formula works out of the box.
@bogdanr bogdanr requested a review from hatifnatt as a code owner October 19, 2021 06:41
Copy link
Collaborator

@hatifnatt hatifnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check failed jobs in pipeline. Particularly you need to fix your commit messages, more about it here https://github.com/saltstack-formulas/.github/blob/master/CONTRIBUTING.rst

I still think default version must be LTS release - https://www.zabbix.com/life_cycle_and_release_policy

Also please check #123 for some thoughts about change of the default version. Especially as I already mentioned here

On the other hand, it's also required to update configuration templates, for agent, server and proxy, and that's a much bigger deal.

Moreover this formula ships it's own SQL files for MySQL, and if you want to update default version, you also need to provide SQL file for that version.
Some info about creating SQL file can be found here #104
This part must be updated too to support new version

{% if zabbix.version_repo|float < 3 -%}
{% set db_version = '22' -%}
{% elif zabbix.version_repo|float < 3.4 -%}
{% set db_version = '30' -%}
{% else -%}
{% set db_version = '34' -%}
{% endif -%}
{% set sql_file = settings.get('sql_file', '/usr/share/zabbix-server-mysql/salt-provided-create-' ~ db_version ~ '.sql') -%}

So changing of the default version isn't that easy as one can thought at first glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants