-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add WithoutBy #515
Open
nicklaus-dev
wants to merge
9
commits into
samber:master
Choose a base branch
from
nicklaus-dev:nick-add-without-by
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add WithoutBy #515
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
107d579
feat: add WithoutBy
nicklaus-dev 3cf2fc4
feat: modify WithoutBy function comment
nicklaus-dev 21f10da
feat: add WithoutBy example test
nicklaus-dev b968056
feat: add README
nicklaus-dev fd53232
feat: modify ExampleWithoutBy comments
nicklaus-dev 4f1f56a
feat: convert Test struct to exported
nicklaus-dev 6b9a75d
feat: fix typo
nicklaus-dev 6e5a845
feat: impove WithoutBy performance
nicklaus-dev c102c03
feat: replace Without implementation by WithoutBy
nicklaus-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: add README
- Loading branch information
commit b9680569a16ceb6ee65169392e0aafa83564b4cc
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit suspicious about the fact the struct is unexported in the example. But also that the fields are unexported.
Based on the extract func, it might work, but I'm unsure, the README should not promote using unexported struct with unexported field.
The _test is in the same package, so it's not a proof it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it's a little bit misleading. I fixed it in README.md and test files. Please review it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes. It's clearer now.