This repository has been archived by the owner on Aug 15, 2023. It is now read-only.
Fix import formatting #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueljsb
force-pushed
the
fix-isort
branch
3 times, most recently
from
01178bb to
981b20c
Compare
Prior to this change, pre-commit started messing up the import sorting with isort. It appears to have been picking up the configuration from `configfiles/.editorconfig` instead of `setup.cfg`. It appears that this is related to PyCQA/isort#1872 and PyCQA/isort#1907. This change explicitly sets the settings file to ensure the right file is used. We also fix the incorrect imports.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, pre-commit started messing up the import sorting
with isort. It appears to have been picking up the configuration from
configfiles/.editorconfiginstead ofsetup.cfg.It appears that this is related to PyCQA/isort#1872 and
PyCQA/isort#1907.
This change explicitly sets the settings file to ensure the right file
is used.
We also fix the incorrect imports.