Skip to content

Tags: sanils/amphtml

Tags

1528909142235

Toggle 1528909142235's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
🐛Report if defaultView is null in preconnect (ampproject#15993)

This is an attempt at fixing ampproject#15883.

The current suspicion is that the setTimeout call inside
`CustomElement#preconnect` delays the call to
`BaseElement#preconnectCallback`. During this delay, the parent window
is destroyed (maybe the iframe is removed from the DOM?), causing
`element.ownerDocument.defaultView` to return `null`.

It's frankly very surprising that timers would fire after a window is
destroyed, so we're only guarding `#preconnectCallback` for now. We may
later extend this to all timers if it fixes the bug.

1528841168349

Toggle 1528841168349's commit message
Sidebar should not close when toolbar is present (ampproject#15990)

* Sidebar should not close  when toolbar is present

* Add jsdoc

1528416097273

Toggle 1528416097273's commit message
Update whitelist (ampproject#15896)

1528391646530

Toggle 1528391646530's commit message
Update whitelist (ampproject#15896)

1528302494869

Toggle 1528302494869's commit message
SwG Release 0.1.22.13 (ampproject#15838)

1528247370025

Toggle 1528247370025's commit message
Attempt to enable Safari 11.0 on SL (ampproject#15798)

* Attempt to enable Safari 11.0 on SL.

* Trigger tests on build system changes.

1527816702194

Toggle 1527816702194's commit message
Fix amp-list w/o amp-bind with disable-faster-amp-list enabled. (ampp…

…roject#15722)

1527809694656

Toggle 1527809694656's commit message
setImportantStyle (ampproject#15671)

1527203409437

Toggle 1527203409437's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Import SwG button stylesheet (ampproject#15566)

1527187520636

Toggle 1527187520636's commit message
adding Amazon Publisher Services Callout URL (ampproject#15537)