Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removing unnecessary use of useBundleDocuments in ReleaseMenu #8231

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Jan 10, 2025

Also passing document count through

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 2:30am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 2:30am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 2:30am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 10, 2025 2:30am
test-next-studio ⬜️ Ignored (Inspect) Jan 10, 2025 2:30am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jan 10, 2025 2:32 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 4s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 38s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 28s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 40s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 10 Jan 2025 02:34:53 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.5 efps (43ms) 17.7 efps (57ms) +14ms (+32.9%) 🔴
article (body) 48.1 efps (21ms) 48.1 efps (21ms) +0ms (-/-%)
article (string inside object) 23.5 efps (43ms) 18.9 efps (53ms) +11ms (+24.7%) 🔴
article (string inside array) 21.3 efps (47ms) 17.2 efps (58ms) +11ms (+23.4%) 🔴
recipe (name) 52.6 efps (19ms) 33.3 efps (30ms) +11ms (+57.9%) 🔴
recipe (description) 62.5 efps (16ms) 35.7 efps (28ms) +12ms (+75.0%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) -1ms (-/-%)
synthetic (title) 19.2 efps (52ms) 8.0 efps (125ms) +73ms (+140.4%) 🔴
synthetic (string inside object) 20.4 efps (49ms) 8.3 efps (121ms) +72ms (+146.9%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 54ms 73ms 507ms 855ms 10.6s
article (body) 21ms 25ms 31ms 216ms 324ms 6.1s
article (string inside object) 43ms 44ms 52ms 222ms 377ms 7.1s
article (string inside array) 47ms 49ms 53ms 67ms 204ms 7.0s
recipe (name) 19ms 20ms 24ms 46ms 0ms 6.6s
recipe (description) 16ms 19ms 20ms 31ms 0ms 4.5s
recipe (instructions) 6ms 7ms 9ms 10ms 0ms 3.0s
synthetic (title) 52ms 54ms 59ms 96ms 330ms 11.6s
synthetic (string inside object) 49ms 51ms 60ms 118ms 912ms 7.9s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 57ms 79ms 86ms 545ms 1384ms 12.0s
article (body) 21ms 25ms 42ms 131ms 384ms 6.1s
article (string inside object) 53ms 55ms 71ms 100ms 843ms 8.3s
article (string inside array) 58ms 63ms 73ms 147ms 1004ms 8.7s
recipe (name) 30ms 33ms 38ms 71ms 14ms 8.1s
recipe (description) 28ms 30ms 32ms 50ms 24ms 5.4s
recipe (instructions) 6ms 7ms 8ms 34ms 0ms 3.0s
synthetic (title) 125ms 131ms 139ms 859ms 5985ms 19.8s
synthetic (string inside object) 121ms 128ms 139ms 662ms 5797ms 15.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 changed the title refactor: removing unnecessary use of useBundleDocuments in ReleaseMe… refactor: removing unnecessary use of useBundleDocuments in ReleaseMenu Jan 10, 2025
@jordanl17 jordanl17 marked this pull request as ready for review January 10, 2025 10:45
@jordanl17 jordanl17 requested a review from a team as a code owner January 10, 2025 10:45
@jordanl17 jordanl17 requested review from pedrobonamin and removed request for a team and pedrobonamin January 10, 2025 10:45
@jordanl17 jordanl17 merged commit e363892 into corel Jan 10, 2025
55 of 57 checks passed
@jordanl17 jordanl17 deleted the corel-310-removing-unnecessary-usebundle-use branch January 10, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant