Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support serverDocumentActions flag in plugins #8247

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Jan 13, 2025

Description

This PR includes some changes necessary to make it possible to opt out from the server document actions through a plugin config.
This will be used to disable this when using the releases plugin, because server actions don't yet support version documents.

This is already merged in corel #8233 , this PR moves this changes to next.

What to review

Testing

Notes for release

n/a

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 13, 2025 12:50
@pedrobonamin pedrobonamin requested review from rexxars and bjoerge and removed request for a team January 13, 2025 12:50
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:54am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:54am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:54am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 13, 2025 0:54am
test-next-studio ⬜️ Ignored (Inspect) Jan 13, 2025 0:54am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jan 13, 2025 12:59 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 39s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 28s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 40s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 13 Jan 2025 13:01:54 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 27.0 efps (37ms) 24.4 efps (41ms) +4ms (+10.8%)
article (body) 78.1 efps (13ms) 72.5 efps (14ms) +1ms (-/-%)
article (string inside object) 26.3 efps (38ms) 26.3 efps (38ms) +0ms (-/-%)
article (string inside array) 24.4 efps (41ms) 25.0 efps (40ms) -1ms (-2.4%)
recipe (name) 45.5 efps (22ms) 47.6 efps (21ms) -1ms (-4.5%)
recipe (description) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) -0ms (-/-%)
synthetic (title) 19.6 efps (51ms) 18.9 efps (53ms) +2ms (+3.9%)
synthetic (string inside object) 20.0 efps (50ms) 20.0 efps (50ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 43ms 66ms 539ms 836ms 11.3s
article (body) 13ms 15ms 19ms 124ms 196ms 5.0s
article (string inside object) 38ms 43ms 47ms 234ms 222ms 7.0s
article (string inside array) 41ms 43ms 48ms 158ms 143ms 6.7s
recipe (name) 22ms 24ms 28ms 45ms 0ms 6.9s
recipe (description) 19ms 20ms 22ms 38ms 0ms 4.6s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 51ms 55ms 63ms 317ms 507ms 12.5s
synthetic (string inside object) 50ms 53ms 59ms 415ms 987ms 8.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 48ms 73ms 450ms 753ms 11.4s
article (body) 14ms 16ms 21ms 137ms 226ms 5.3s
article (string inside object) 38ms 40ms 44ms 189ms 228ms 6.7s
article (string inside array) 40ms 42ms 47ms 152ms 160ms 6.6s
recipe (name) 21ms 24ms 27ms 43ms 0ms 7.1s
recipe (description) 19ms 20ms 22ms 32ms 0ms 4.5s
recipe (instructions) 6ms 7ms 8ms 17ms 0ms 3.1s
synthetic (title) 53ms 54ms 61ms 70ms 316ms 11.4s
synthetic (string inside object) 50ms 55ms 63ms 529ms 1076ms 8.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin added this pull request to the merge queue Jan 13, 2025
Merged via the queue into next with commit 78318f3 Jan 13, 2025
57 checks passed
@pedrobonamin pedrobonamin deleted the corel-315 branch January 13, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants