-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): use displayed value for document title #8268
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No changes to documentation |
Component Testing Report Updated Jan 14, 2025 12:01 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Tue, 14 Jan 2025 12:03:43 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one!
Description
useDocumentTitle
is checking for the existence ofeditState.draft
|editState.published
With the introduction of
releases
this is error prone, because now we can display different values, not only draft or published inside the document pane.This changes the hook to depend on the
displayed
value, which will be the value shown in the form.What to review
Testing
Notes for release
chore(core): use displayed value for document title