Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): export EditPortal as beta #8270

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix(core): export EditPortal as beta #8270

merged 1 commit into from
Jan 14, 2025

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Jan 14, 2025

Description

export <EditPortal/> as @beta

What to review

Testing

Notes for release

n/a

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 14, 2025 13:57
@pedrobonamin pedrobonamin requested review from bjoerge and removed request for a team January 14, 2025 13:57
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 2:04pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 2:04pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 2:04pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 14, 2025 2:04pm
test-next-studio ⬜️ Ignored (Inspect) Jan 14, 2025 2:04pm

@pedrobonamin pedrobonamin requested review from cngonzalez and removed request for bjoerge January 14, 2025 13:57
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jan 14, 2025 2:08 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 38s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 28s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 40s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 23s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Tue, 14 Jan 2025 14:09:20 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.7 efps (44ms) 20.2 efps (50ms) +6ms (+12.5%)
article (body) 54.9 efps (18ms) 59.7 efps (17ms) -1ms (-8.0%)
article (string inside object) 22.7 efps (44ms) 23.3 efps (43ms) -1ms (-2.3%)
article (string inside array) 20.4 efps (49ms) 19.6 efps (51ms) +2ms (+4.1%)
recipe (name) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (description) 58.8 efps (17ms) 58.8 efps (17ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%)
synthetic (title) 18.9 efps (53ms) 18.7 efps (54ms) +1ms (+0.9%)
synthetic (string inside object) 18.5 efps (54ms) 19.0 efps (53ms) -2ms (-2.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 47ms 81ms 463ms 800ms 11.1s
article (body) 18ms 23ms 32ms 270ms 472ms 6.4s
article (string inside object) 44ms 46ms 47ms 165ms 197ms 7.3s
article (string inside array) 49ms 51ms 57ms 81ms 360ms 7.7s
recipe (name) 19ms 21ms 24ms 37ms 0ms 7.9s
recipe (description) 17ms 18ms 20ms 24ms 0ms 4.3s
recipe (instructions) 6ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 53ms 57ms 60ms 143ms 605ms 12.1s
synthetic (string inside object) 54ms 57ms 64ms 468ms 1299ms 8.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 50ms 74ms 92ms 540ms 1192ms 12.3s
article (body) 17ms 20ms 25ms 168ms 277ms 6.0s
article (string inside object) 43ms 46ms 51ms 85ms 298ms 7.4s
article (string inside array) 51ms 53ms 58ms 233ms 575ms 7.9s
recipe (name) 19ms 20ms 23ms 38ms 0ms 7.4s
recipe (description) 17ms 18ms 20ms 32ms 0ms 4.4s
recipe (instructions) 5ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 54ms 56ms 61ms 301ms 1056ms 13.1s
synthetic (string inside object) 53ms 57ms 87ms 292ms 824ms 8.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@cngonzalez cngonzalez added this pull request to the merge queue Jan 14, 2025
Merged via the queue into next with commit c65b13c Jan 14, 2025
58 checks passed
@cngonzalez cngonzalez deleted the edit-portal-beta branch January 14, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants