TEZ-3589. add a unit test for amKeepAlive not being shutdown if an app

takes a long time to launch. (sseth)

CHANGES.txt

@@ -7,6 +7,7 @@ INCOMPATIBLE CHANGES
 
 ALL CHANGES:
 
+  TEZ-3589. add a unit test for amKeepAlive not being shutdown if an app takes a long time to launch.
   TEZ-3417. Reduce sleep time on AM shutdown to reduce test runtimes
   TEZ-3582. Exception swallowed in PipelinedSorter causing incorrect results.
   TEZ-3584. amKeepAliveService in TezClient should shutdown in case of AM failure.

tez-api/src/test/java/org/apache/tez/client/TestTezClient.java

@@ -829,9 +829,24 @@ public void testAMClientHeartbeat() throws Exception {
 
   }
 
+  @Test(timeout = 20000)
+  public void testAMHeartbeatFailOnGetAMProxy_AppNotStarted() throws Exception {
+    int amHeartBeatTimeoutSecs = 3;
+    TezConfiguration conf = new TezConfiguration();
+    conf.setInt(TezConfiguration.TEZ_AM_CLIENT_HEARTBEAT_TIMEOUT_SECS, amHeartBeatTimeoutSecs);
 
-  @Test(timeout = 10000)
-  public void testAMHeartbeatFailOnGetAMProxy() throws Exception {
+    final TezClientForTest client = configureAndCreateTezClient(conf);
+    client.callRealGetSessionAMProxy = true;
+    client.start();
+
+    when(client.mockYarnClient.getApplicationReport(client.mockAppId).getYarnApplicationState())
+        .thenReturn(YarnApplicationState.ACCEPTED);
+    Thread.sleep(2 * amHeartBeatTimeoutSecs * 1000);
+    assertFalse(client.getAMKeepAliveService().isTerminated());
+  }
+
+  @Test(timeout = 20000)
+  public void testAMHeartbeatFailOnGetAMProxy_AppFailed() throws Exception {
     int amHeartBeatTimeoutSecs = 3;
     TezConfiguration conf = new TezConfiguration();
     conf.setInt(TezConfiguration.TEZ_AM_CLIENT_HEARTBEAT_TIMEOUT_SECS, amHeartBeatTimeoutSecs);
@@ -846,7 +861,7 @@ public void testAMHeartbeatFailOnGetAMProxy() throws Exception {
     assertTrue(client.getAMKeepAliveService().isTerminated());
   }
 
-  @Test(timeout = 12000)
+  @Test(timeout = 20000)
   public void testAMHeartbeatFailOnGetAMStatus() throws Exception {
     int amHeartBeatTimeoutSecs = 3;
     TezConfiguration conf = new TezConfiguration();