Cleaning up in response to code review

sargamm · Jan 10, 2015 · 042684d · 042684d
1 parent 16307d5
commit 042684d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/core/templates/dev/head/editor/EditorServices.js b/core/templates/dev/head/editor/EditorServices.js
@@ -831,8 +831,8 @@ oppia.factory('computeGraphService', [function() {
       nodes[stateName] = stateName;
 
       var handlers = states[stateName].widget.handlers;
-      for (h = 0; h < handlers.length; h++) {
-        ruleSpecs = handlers[h].rule_specs;
+      for (var h = 0; h < handlers.length; h++) {
+        var ruleSpecs = handlers[h].rule_specs;
         for (i = 0; i < ruleSpecs.length; i++) {
           links.push({
             source: stateName,

diff --git a/core/templates/dev/head/editor/ExplorationStatistics.js b/core/templates/dev/head/editor/ExplorationStatistics.js
@@ -63,7 +63,7 @@ oppia.controller('ExplorationStatistics', [
       $http.get(explorationDataUrl).then(function(response) {
         var states = response.data.states;
         var initStateName = response.data.init_state_name;
-        $scope.graphData = computeGraphService.compute(initStateName, states);
+        $scope.statsGraphData = computeGraphService.compute(initStateName, states);
       });
 
       var data = response.data;

diff --git a/core/templates/dev/head/editor/exploration_statistics.html b/core/templates/dev/head/editor/exploration_statistics.html
@@ -27,8 +27,7 @@ <h4>Common learner paths</h4>
         <div class="container">
           <div class="row">
             <div class="col-lg-12 col-md-12 col-sm-12">
-              <!-- TODO(sll): Instead of using the current graph, use the graph that corresponds to the version of the exploration being looked at (or the current graph if the version is 'none' or 'all'). -->
-              <div state-graph-viz graph-data="graphData" node-fill="darkseagreen" opacity-map="statsGraphOpacities" highlight-states="highlightStates" state-stats="stateStats" on-click-function="onClickStateInStatsGraph">
+              <div state-graph-viz graph-data="statsGraphData" node-fill="darkseagreen" opacity-map="statsGraphOpacities" highlight-states="highlightStates" state-stats="stateStats" on-click-function="onClickStateInStatsGraph">
               </div>
             </div>
           </div>