feature(explain): add a simple explain join to display the join orders

sarvex · Mar 22, 2023 · 051ca96 · 051ca96
1 parent 025cac0
commit 051ca96
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/src/query/service/src/interpreters/interpreter_explain.rs b/src/query/service/src/interpreters/interpreter_explain.rs
@@ -212,8 +212,7 @@ impl ExplainInterpreter {
         plan: &PhysicalPlan,
         metadata: &MetadataRef,
     ) -> Result<Vec<DataBlock>> {
-        let prof = ProfSpanSetRef::default();
-        let result = plan.format_join(metadata, &prof)?.format_pretty()?;
+        let result = plan.format_join(metadata)?.format_pretty()?;
         let line_split_result: Vec<&str> = result.lines().collect();
         let formatted_plan = StringType::from_data(line_split_result);
         Ok(vec![DataBlock::new_from_columns(vec![formatted_plan])])

diff --git a/src/query/sql/src/executor/format.rs b/src/query/sql/src/executor/format.rs
@@ -56,11 +56,7 @@ impl PhysicalPlan {
         to_format_tree(self, &metadata, &prof_span_set)
     }
 
-    pub fn format_join(
-        &self,
-        metadata: &MetadataRef,
-        prof_span_set: &ProfSpanSetRef,
-    ) -> Result<FormatTreeNode<String>> {
+    pub fn format_join(&self, metadata: &MetadataRef) -> Result<FormatTreeNode<String>> {
         match self {
             PhysicalPlan::TableScan(plan) => {
                 if plan.table_index == DUMMY_TABLE_INDEX {
@@ -82,8 +78,8 @@ impl PhysicalPlan {
                 ))
             }
             PhysicalPlan::HashJoin(plan) => {
-                let build_child = plan.build.format_join(metadata, prof_span_set)?;
-                let probe_child = plan.probe.format_join(metadata, prof_span_set)?;
+                let build_child = plan.build.format_join(metadata)?;
+                let probe_child = plan.probe.format_join(metadata)?;
 
                 let children = vec![
                     FormatTreeNode::with_children("Build".to_string(), vec![build_child]),
@@ -98,7 +94,7 @@ impl PhysicalPlan {
             other => {
                 let children = other
                     .children()
-                    .map(|child| child.format_join(metadata, prof_span_set))
+                    .map(|child| child.format_join(metadata))
                     .collect::<Result<Vec<FormatTreeNode<String>>>>()?;
 
                 if children.len() == 1 {