Fix noCompatMode flag for base60

sashashura · Dec 11, 2020 · dc44dd3 · dc44dd3
1 parent a003121
commit dc44dd3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/lib/dumper.js b/lib/dumper.js
@@ -385,10 +385,10 @@ function writeScalar(state, string, level, iskey) {
     if (string.length === 0) {
       return state.quotingType === QUOTING_TYPE_DOUBLE ? '""' : "''";
     }
-    if (!state.noCompatMode &&
-        DEPRECATED_BOOLEANS_SYNTAX.indexOf(string) !== -1 ||
-        DEPRECATED_BASE60_SYNTAX.test(string)) {
-      return state.quotingType === QUOTING_TYPE_DOUBLE ? ('"' + string + '"') : ("'" + string + "'");
+    if (!state.noCompatMode) {
+      if (DEPRECATED_BOOLEANS_SYNTAX.indexOf(string) !== -1 || DEPRECATED_BASE60_SYNTAX.test(string)) {
+        return state.quotingType === QUOTING_TYPE_DOUBLE ? ('"' + string + '"') : ("'" + string + "'");
+      }
     }
 
     var indent = state.indent * Math.max(1, level); // no 0-indent scalars

diff --git a/test/issues/0027.js b/test/issues/0027.js
@@ -45,4 +45,12 @@ describe('Should dump numbers in YAML 1.2 format', function () {
       assert.strictEqual(yaml.dump(sample, { noCompatMode: false }), "'" + sample + "'\n");
     });
   });
+
+  it('should not quote base60 in noCompatMode', function () {
+    var tests = '1:23 1:23.45';
+
+    tests.split(' ').forEach(function (sample) {
+      assert.strictEqual(yaml.dump(sample, { noCompatMode: true }), sample + '\n');
+    });
+  });
 });