Skip to content

Commit

Permalink
x86: Remove HAVE_ACPI_RESUME
Browse files Browse the repository at this point in the history
These are currently dead codes. Until we have complete ACPI support,
we don't know if it works or not. Remove to avoid confusion.

Signed-off-by: Bin Meng <[email protected]>
Acked-by: Simon Glass <[email protected]>
Tested-by: Simon Glass <[email protected]>
  • Loading branch information
lbmeng committed Dec 9, 2015
1 parent d475d59 commit 789fa27
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 44 deletions.
9 changes: 0 additions & 9 deletions arch/x86/cpu/ivybridge/cpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -298,16 +298,7 @@ int print_cpuinfo(void)
pm1_cnt = inl(DEFAULT_PMBASE + PM1_CNT);

if ((pm1_sts & WAK_STS) && ((pm1_cnt >> 10) & 7) == 5) {
#if CONFIG_HAVE_ACPI_RESUME
debug("Resume from S3 detected.\n");
boot_mode = PEI_BOOT_RESUME;
/* Clear SLP_TYPE. This will break stage2 but
* we care for that when we get there.
*/
outl(pm1_cnt & ~(7 << 10), DEFAULT_PMBASE + PM1_CNT);
#else
debug("Resume from S3 detected, but disabled.\n");
#endif
} else {
/*
* TODO: An indication of life might be possible here (e.g.
Expand Down
9 changes: 0 additions & 9 deletions arch/x86/cpu/ivybridge/lpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,15 +240,6 @@ static void pch_rtc_init(pci_dev_t dev)
}
debug("rtc_failed = 0x%x\n", rtc_failed);

#if CONFIG_HAVE_ACPI_RESUME
/* Avoid clearing pending interrupts and resetting the RTC control
* register in the resume path because the Linux kernel relies on
* this to know if it should restart the RTC timerqueue if the wake
* was due to the RTC alarm.
*/
if (acpi_get_slp_type() == 3)
return;
#endif
/* TODO: Handle power failure */
if (rtc_failed)
printf("RTC power failed\n");
Expand Down
16 changes: 0 additions & 16 deletions arch/x86/cpu/ivybridge/northbridge.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,20 +169,4 @@ void northbridge_init(pci_dev_t dev)

void northbridge_enable(pci_dev_t dev)
{
#if CONFIG_HAVE_ACPI_RESUME
switch (x86_pci_read_config32(dev, SKPAD)) {
case 0xcafebabe:
debug("Normal boot.\n");
apci_set_slp_type(0);
break;
case 0xcafed00d:
debug("S3 Resume.\n");
apci_set_slp_type(3);
break;
default:
debug("Unknown boot method, assuming normal.\n");
apci_set_slp_type(0);
break;
}
#endif
}
1 change: 0 additions & 1 deletion board/google/chromebook_link/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
def_bool y
select X86_RESET_VECTOR
select NORTHBRIDGE_INTEL_IVYBRIDGE
select HAVE_ACPI_RESUME
select BOARD_ROMSIZE_KB_8192

config PCIE_ECAM_BASE
Expand Down
1 change: 0 additions & 1 deletion board/google/chromebox_panther/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
def_bool y
select X86_RESET_VECTOR
select NORTHBRIDGE_INTEL_IVYBRIDGE
select HAVE_ACPI_RESUME
select BOARD_ROMSIZE_KB_8192

config SYS_CAR_ADDR
Expand Down
8 changes: 0 additions & 8 deletions drivers/pci/pci_rom.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,13 @@
#include <video_fb.h>
#include <linux/screen_info.h>

#ifdef CONFIG_HAVE_ACPI_RESUME
#include <asm/acpi.h>
#endif

__weak bool board_should_run_oprom(pci_dev_t dev)
{
return true;
}

static bool should_load_oprom(pci_dev_t dev)
{
#ifdef CONFIG_HAVE_ACPI_RESUME
if (acpi_get_slp_type() == 3)
return false;
#endif
if (IS_ENABLED(CONFIG_ALWAYS_LOAD_OPROM))
return 1;
if (board_should_run_oprom(dev))
Expand Down

0 comments on commit 789fa27

Please sign in to comment.