Errorreporting

README.md

@@ -63,6 +63,10 @@ tryfi.pets[0].isLost
 * [TryFi](https://tryfi.com/)
 
 # Version History
+# 0.0.13
+* Enhancement - removed error logging where not required
+* Fix - resolved issue where the variables are unbound in the login function
+
 ## 0.0.12
 * Enhancement - added Sentry for capturing errors by further only capturing exceptions
 

pytryfi/__init__.py

@@ -22,7 +22,6 @@ def __init__(self, username=None, password=None):
             sentry = sentry_sdk.init(
                     SENTRY_URL,
                     release=PYTRYFI_VERSION,
-                    traces_sample_rate=0,
                 )
             self._api_host = API_HOST_URL_BASE
             self._session = requests.Session()
@@ -168,6 +167,7 @@ def session(self):
 
     # login to the api and get a session
     def login(self):
+        error = None
         url = API_HOST_URL_BASE + API_LOGIN
         params={
                 'email' : self._username,
@@ -178,26 +178,28 @@ def login(self):
         try:
             response = self._session.post(url, data=params)
             response.raise_for_status()
+            #validate if the response contains error or not
+            try:
+                error = response.json()['error']
+            except Exception as e:
+                #capture_exception(e)
+                error = None
+            #if error set or response is non-200
+            if error or not response.ok:
+                errorMsg = error['message']
+                LOGGER.error(f"Cannot login, response: ({response.status_code}): {errorMsg} ")
+                capture_exception(errorMsg)
+                raise Exception("TryFiLoginError")
+
+            #storing cookies but don't need them. Handled by session mgmt
+            self._cookies = response.cookies
+            #store unique userId from login for future use
+            self._userId = response.json()['userId']
+            self._sessionId = response.json()['sessionId']
+            LOGGER.debug(f"Successfully logged in. UserId: {self._userId}")
         except requests.RequestException as e:
             LOGGER.error(f"Cannot login, error: ({e})")
             capture_exception(e)
             raise requests.RequestException(e)
         except Exception as e:
             capture_exception(e)
-        error = None
-        try:
-            error = response.json()['error']
-        except Exception as e:
-            capture_exception(e)
-            error = None
-        if error or not response.ok:
-            errorMsg = error['message']
-            LOGGER.error(f"Cannot login, response: ({response.status_code}): {errorMsg} ")
-            capture_exception(errorMsg)
-            raise Exception("TryFiLoginError")
-        #storing cookies but don't need them. Handled by session mgmt
-        self._cookies = response.cookies
-        #store unique userId from login for future use
-        self._userId = response.json()['userId']
-        self._sessionId = response.json()['sessionId']
-        LOGGER.debug(f"Successfully logged in. UserId: {self._userId}")

pytryfi/const.py

@@ -1,6 +1,6 @@
 SENTRY_URL = "https://[email protected]/5735605"
 
-PYTRYFI_VERSION = "0.0.12"
+PYTRYFI_VERSION = "0.0.13"
 
 API_HOST_URL_BASE   = "https://api.tryfi.com"
 API_GRAPHQL         = "/graphql"

pytryfi/fiPet.py

@@ -34,7 +34,7 @@ def setPetDetailsJSON(self, petJSON):
         try:
             self._photoLink = petJSON['photos']['first']['image']['fullSize']
         except Exception as e:
-            capture_exception(e)
+            #capture_exception(e)
             LOGGER.warning(f"Cannot find photo of your pet. Defaulting to empty string.")
             self._photoLink = ""
         try:
@@ -66,7 +66,7 @@ def setCurrentLocation(self, activityJSON):
                 self._currPlaceName = activityJSON['place']['name']
                 self._currPlaceAddress = activityJSON['place']['address']
             except Exception as e:
-                capture_exception(e)
+                #capture_exception(e)
                 LOGGER.warning("Could not set place, defaulting to Unknown")
                 self._currPlaceName = "UNKNOWN"
                 self._currPlaceAddress = "UNKNOWN"