Improve GADT reasoning for pattern alternatives #23205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it fails, but now it is ok
There was a problem hiding this comment.
Pull Request Overview
This PR refines GADT constraint handling for pattern alternatives by collecting constraints from each case and using their common, necessary constraint instead of discarding all GADT reasoning.
- Collects GADT constraints per alternative in
Typer.scalaand restores the weakest common constraint if it exists. - Adds
necessaryGadtConstraintinTypeComparer.scalato compute a constraint subsumed by all alternatives. - Updates existing positive and negative tests to reflect the new behavior.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/pos/gadt-alt-doc1.scala | Adds a positive test demonstrating a disallowed alternative now errors. |
| tests/neg/gadt-alternatives.scala & various gadt-alt-expr*.scala | Updates negative tests to expect new accept/reject behavior. |
| compiler/src/dotty/tools/dotc/typer/Typer.scala | Collects and aggregates GADT constraints instead of discarding them. |
| compiler/src/dotty/tools/dotc/core/TypeComparer.scala | Introduces necessaryGadtConstraint and related import updates. |
Comments suppressed due to low confidence (1)
compiler/src/dotty/tools/dotc/core/TypeComparer.scala:28
- [nitpick] The combined import
import scala.util.boundary, boundary.breakmay importboundary.breakfrom the wrong package; preferimport scala.util.boundary.breakor separate the imports to ensure the correct symbol is brought into scope.
import scala.util.boundary, boundary.break
| val trees1 = tree.trees.mapconserve: t => | ||
| nestedCtx.gadtState.restore(preGadt) | ||
| val res = typed(t, pt)(using nestedCtx) | ||
| gadtConstrs += ctx.gadt |
There was a problem hiding this comment.
Recording ctx.gadt likely captures the outer context rather than the updated nested context; it should use nestedCtx.gadt to collect the actual constraints produced by each alternative.
Suggested change
| gadtConstrs += ctx.gadt | |
| gadtConstrs += nestedCtx.gadt |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22882.
Previously, for a pattern alternative:
we ignore GADT constraints derived from it, which is too restrictive. Now we try to find a GADT constraint that is subsumed by all and use it, and only ignore GADT constraints when such a constraint cannot be found.