Support Mirror for generic tuples arity > 22 #23363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Jun 14, 2025
|
|
||
| summon[Tuple.Size[Tuple23] =:= 23] | ||
| val m = summon[scala.deriving.Mirror.Of[Tuple23]] | ||
| summon[m.MirroredLabel =:= "Tuple23"] |
There was a problem hiding this comment.
I guess this is the main bike-shedding moment - i.e. should it include arity, or just Tuple (or another variant) - i.e. case class can evolve over time to add new fields but its MirroredLabel doesn't change - so I dont think unique label is necessary.
There was a problem hiding this comment.
should also update the docs (or create an issue to) for Mirror generation here https://www.scala-lang.org/api/3.7.1/docs/docs/reference/contextual/derivation.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15398