replace scala.collection.concurrent java files
#24005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previous solution to private volatile |
|
field is |
xuwei-k
force-pushed
the
scala-collection-concurrent-java-files
branch
from
69b79d7 to
09d1e96
Compare
xuwei-k
commented
Sep 21, 2025
|
|
||
| @transient | ||
| val inodeupdater: AtomicReferenceFieldUpdater[INodeBase[_, _], MainNode[_, _]] = AtomicReferenceFieldUpdater.newUpdater(classOf[INodeBase[_, _]], classOf[MainNode[_, _]], "mainnode") | ||
| val inodeupdater: AtomicReferenceFieldUpdater[INodeBase[_, _], MainNode[_, _]] = INodeBase.updater |
There was a problem hiding this comment.
Maybe TrieMap.inodeupdater is unused. but error without this change. Should we deprecate this field? 🤔
Caused by: java.lang.RuntimeException: java.lang.IllegalAccessException: class scala.collection.concurrent.TrieMap$ cannot access a member of class scala.collection.concurrent.INodeBase with modifiers "private volatile"
at java.base/java.util.concurrent.atomic.AtomicReferenceFieldUpdater$AtomicReferenceFieldUpdaterImpl.<init>(AtomicReferenceFieldUpdater.java:351)
at java.base/java.util.concurrent.atomic.AtomicReferenceFieldUpdater.newUpdater(AtomicReferenceFieldUpdater.java:115)
at scala.collection.concurrent.TrieMap$.<clinit>(TrieMap.scala:1052)
|
🤔 |
|
Better verify with javap too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala/scala@5fe2d8b
Scala 3 has
@staticannotation.I think it's time to convert to
.scalafrom.java.