-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add support for Scala 2.12.16 #4010
Conversation
val scala213 = "2.13.8" | ||
val scala3 = "3.1.2" | ||
val nextScala3RC = "3.1.3-RC4" | ||
val sbtScala = "2.12.14" | ||
val ammonite212Version = scala212 | ||
val ammonite212Version = "2.12.15" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ammonite 2.12 stays on 2.12.15?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ammonite is not yet available for 2.12.16
check( | ||
"kind-projector", | ||
"kind-projector".tag(IgnoreScalaVersion("2.12.16")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried fixing it, but this would require a lot of work and I would rather focus on Scala 3 when fixing error in the compiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe turn it into an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean in practice? Will metals users have issues with kind-projector on Scala 2.12.16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe turn it into an issue?
I mean, I could, but in reality I don't think it will be a high priority for anyone, so we would need to fix it ourselves :/ I will raise i , maybe someone has some ideas.
What does this mean in practice? Will metals users have issues with kind-projector on Scala 2.12.16?
I actually updated to the newest version and it seems the users already have issues 😓 At least for this particular case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check( | ||
"kind-projector", | ||
"kind-projector".tag(IgnoreScalaVersion("2.12.16")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe turn it into an issue?
No description provided.