feat: [SP-2400] - Create crypto sub command #117
Conversation
WalkthroughThis update introduces a new top-level Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant Cryptography
participant ScanossGrpc
User->>CLI: Run "crypto algorithms" command
CLI->>Cryptography: Create config and instance
Cryptography->>ScanossGrpc: Request algorithms (with or without range)
ScanossGrpc-->>Cryptography: Return algorithms data
Cryptography->>CLI: Present data in requested format
CLI-->>User: Output results
Suggested labels
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
src/scanoss/constants.py (1)
14-15: 🛠️ Refactor suggestionAvoid proliferating timeout constants – reuse an existing one instead of
DEFAULT_API_TIMEOUT.
DEFAULT_TIMEOUT(180 s) andDEFAULT_SC_TIMEOUT(600 s) already exist. Adding another constant with the same value introduces ambiguity and the risk that different modules silently diverge.
Prefer re-usingDEFAULT_SC_TIMEOUT(or renaming it to a more generic name) and delete the new symbol, or alias it explicitly:-DEFAULT_API_TIMEOUT = 600 +# Alias for backward-compatibility – keeps a single source of truth +DEFAULT_API_TIMEOUT = DEFAULT_SC_TIMEOUTThis keeps callers consistent and simplifies future changes.
🧹 Nitpick comments (4)
src/scanoss/scanossgrpc.py (1)
579-611: Harmonise response handling and fix misleading docstrings in the new crypto helpers.
_call_rpcalready includesstatusin the returned dict, whereas the older, hand-rolled helpers remove it (del resp_dict['status']).
Decide on one convention so downstream code doesn’t have to special-case crypto calls.The docstrings reference protobuf classes (
AlgorithmResponse,AlgorithmsInRangeResponse) that are no longer imported and not what the method actually returns (adict).
Clarify the return type and remove stale names.- Returns: - Optional[Dict]: AlgorithmResponse, or None if the request was not successfull + Returns: + Optional[Dict]: Parsed response dictionary (includes 'status' key) or None on failure
- Consider wrapping the call in
try/except ScanossGrpcErrorand logging like other helpers, to keep behaviour consistent.src/scanoss/cli.py (1)
1419-1451:crypto_algorithmsswallows all exceptions – surface actionable errors to users.The broad
except Exception as eprints a generic message and exits.
Consider catchingScanossGrpcErrorseparately to show server details, and log unexpected errors with stack traces when--debugis set:- except Exception as e: - print_stderr(f'ERROR: {e}') - sys.exit(1) + except ScanossGrpcError as e: + print_stderr(f'API ERROR: {e}') + sys.exit(1) + except Exception as e: + if args.debug: + import traceback; traceback.print_exc() + print_stderr(f'UNEXPECTED ERROR: {e}') + sys.exit(1)This improves debuggability without overwhelming normal users.
src/scanoss/cryptography.py (2)
27-37: Inconsistent default types returned from argument parsing
getattr(args, 'debug', None)(and similar) returnsNonewhen the flag is absent, whereas the dataclass expects booleans.
Down-stream truthiness checks (if self.debug:) work, but mixingNone/boolcomplicates typing and mypy.- debug=getattr(args, 'debug', None), + debug=bool(getattr(args, 'debug', False)),Apply the same pattern to
trace,quiet, andget_range.
132-135:present()can be invoked beforeget_algorithms()If the caller forgets to call
get_algorithms()first, the presenter will emitnull, which is misleading.
Consider asserting thatself.resultsis populated or callingget_algorithms()implicitly.if self.results is None: raise ScanossCryptographyError('No data to present. Call get_algorithms() first.')
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/scanoss/cli.py(9 hunks)src/scanoss/constants.py(1 hunks)src/scanoss/cryptography.py(1 hunks)src/scanoss/scanossgrpc.py(1 hunks)src/scanoss/utils/file.py(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (3)
src/scanoss/scanossgrpc.py (1)
src/scanoss/api/cryptography/v2/scanoss_cryptography_pb2_grpc.py (4)
GetAlgorithms(64-69)GetAlgorithms(162-176)GetAlgorithmsInRange(71-76)GetAlgorithmsInRange(179-193)
src/scanoss/cli.py (3)
src/scanoss/cryptography.py (4)
Cryptography(40-134)create_cryptography_config_from_args(27-37)get_algorithms(76-97)present(132-134)src/scanoss/scanossgrpc.py (2)
create_grpc_config_from_args(649-662)ScanossGrpc(94-626)src/scanoss/scanossbase.py (1)
print_stderr(45-49)
src/scanoss/cryptography.py (5)
src/scanoss/scanossbase.py (1)
ScanossBase(28-107)src/scanoss/scanossgrpc.py (2)
get_crypto_algorithms_in_range_for_purl(596-611)get_crypto_algorithms_for_purl(579-594)src/scanoss/utils/abstract_presenter.py (1)
AbstractPresenter(6-103)src/scanoss/utils/file.py (1)
validate_json_file(44-84)src/scanoss/cli.py (1)
print_stderr(80-84)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (3)
src/scanoss/utils/file.py (1)
52-53:✅ Verification successful
Double-check all call sites now that the return type changed to an object.
validate_json_fileno longer returns a(bool, str)tuple but aJsonValidationdataclass.
Please verify every invocation (e.g.,is_valid, msg = …) and update them accordingly to avoid runtime unpacking errors.You can quickly locate potential offenders:
🏁 Script executed:
#!/bin/bash # Find places still assuming a 2-tuple return value. rg -n "validate_json_file\(.*\)" | rg -v "\.is_valid"Length of output: 411
Let’s inspect each call site to see how the return value is consumed:
🏁 Script executed:
#!/bin/bash # Show context around validate_json_file invocations to verify tuple unpacking vs. dataclass usage rg -n -C2 "validate_json_file" src/scanoss/cryptography.py rg -n -C2 "validate_json_file" src/scanoss/scanoss_settings.py rg -n -C2 "validate_json_file" src/scanoss/cli.pyLength of output: 1393
All
validate_json_filecall sites correctly useJsonValidationfieldsI checked the three invocations in:
src/scanoss/cryptography.py(usesinput_file_validation.is_valid)src/scanoss/scanoss_settings.py(usesresult.is_validandresult.error_code)src/scanoss/cli.py(usesresult.is_validandresult.error)None of these sites still unpack a
(bool, str)tuple. You can safely ignore the unpacking warning—no further updates are needed.src/scanoss/cli.py (2)
357-386: Sub-parser adds a--range/-roption that shadows Python’s built-inrange.Shadowing isn’t fatal here (it lives only in
argparse.Namespace), but it hampers readability and may confuse linters.
Rename to something more explicit, e.g.,--version-range / -vr, and adjustCryptographyConfig.get_rangeaccordingly.-p_crypto_algorithms.add_argument( - '--range', - '-r', +p_crypto_algorithms.add_argument( + '--version-range', + '-vr',[ suggest_nitpick ]
398-400: Default timeout uses the new constant – ensure it remains in sync with gRPC client defaults.
ScanossGrpc.__init__defaultstimeout=600. If the earlier comment about consolidating timeout constants is addressed, remember to import the single agreed-upon constant here to avoid silent drift.
There was a problem hiding this comment.
Actionable comments posted: 5
🔭 Outside diff range comments (1)
src/scanoss/cli.py (1)
1466-1505: 🛠️ Refactor suggestionGood implementation of crypto_algorithms command handler.
The function properly validates input arguments, checks for certificate file existence, creates configurations, and handles errors. However, the PAC file functionality is marked as a TODO and is commented out.
Implement the TODO for PAC file support or remove the commented-out code to avoid confusion. This functionality appears to be implemented in other command handlers (like
comp_vulnsat line 1606).- # TODO: Add PAC file support - # pac_file = get_pac_file(config.pac) + pac_file = get_pac_file(args.pac) + if pac_file: + # Use PAC file if provided + grpc_config.pac = pac_file
♻️ Duplicate comments (1)
src/scanoss/cryptography.py (1)
143-172:⚠️ Potential issueThe _build_purls_request method has a potential issue with single string handling.
While the method correctly handles both input file and direct purl list cases, there's an issue with how it processes the
purlattribute.If
self.config.purlis a single string (rather than a list), iterating over it will treat each character as a separate purl. Fix this by ensuring proper handling of both single string and list cases:if self.config.purl: - return {'purls': [{'purl': p} for p in self.config.purl]} + # Handle both single string and list cases + purls = self.config.purl + if isinstance(purls, str): + purls = [purls] + return {'purls': [{'purl': p} for p in purls]}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/scanoss/cli.py(9 hunks)src/scanoss/cryptography.py(1 hunks)src/scanoss/scanossgrpc.py(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
src/scanoss/scanossgrpc.py (1)
src/scanoss/api/cryptography/v2/scanoss_cryptography_pb2_grpc.py (10)
GetAlgorithms(64-69)GetAlgorithms(162-176)GetAlgorithmsInRange(71-76)GetAlgorithmsInRange(179-193)GetEncryptionHints(92-97)GetEncryptionHints(230-244)GetHintsInRange(85-90)GetHintsInRange(213-227)GetVersionsInRange(78-83)GetVersionsInRange(196-210)
src/scanoss/cli.py (3)
src/scanoss/cryptography.py (6)
Cryptography(40-176)create_cryptography_config_from_args(27-37)get_algorithms(76-96)present(174-176)get_encryption_hints(98-120)get_versions_in_range(122-141)src/scanoss/scanossgrpc.py (3)
create_grpc_config_from_args(700-713)ScanossGrpc(94-677)ScanossGrpcError(77-82)src/scanoss/scanossbase.py (1)
print_stderr(45-49)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (25)
src/scanoss/scanossgrpc.py (5)
579-594: Well-structured API method for retrieving cryptographic algorithms.The implementation follows a consistent pattern with other gRPC methods in the class, leveraging the
_call_rpchelper method for standardized request handling and error management. This promotes code reuse and maintainability.
596-611: Excellent implementation of range-based algorithm retrieval.This method provides the capability to query algorithms within a specific version range, complementing the basic algorithm retrieval functionality. The consistent use of the
_call_rpchelper method maintains a uniform approach across all cryptography API methods.
613-628: Clean implementation of encryption hints retrieval.The method follows the established pattern of using the
_call_rpchelper, maintaining consistency with other API methods. The docstring clearly explains the purpose, parameters, and return values.
630-645: Well-designed method for retrieving encryption hints within a range.The implementation maintains a consistent pattern with other gRPC methods, leveraging the standardized
_call_rpchelper. The debug message passed to the helper method is descriptive and helpful for troubleshooting.
647-662: Effective implementation of version range retrieval.This method completes the set of cryptography-related gRPC methods, providing a way to query component versions that contain or don't contain cryptographic algorithms. The consistent approach across all these methods will make the codebase easier to maintain.
src/scanoss/cli.py (9)
34-34: Good import of new cryptography module.The import brings in the new
Cryptographyclass and helper function needed for the new CLI commands.
54-54: Appropriate use of the new API timeout constant.Using a named constant for the default timeout improves maintainability and provides consistency across the application.
357-406: Well-structured new crypto command with appropriate sub-commands.This new command structure separates cryptography functionality into its own top-level command with clear sub-commands for different operations. The
required=Trueparameter on line 369 ensures that a sub-command must be specified, and the help text for each command is descriptive and helpful.
408-409: Good inclusion of crypto commands in the common purl options group.This ensures that all commands that process PURLs have consistent options available.
413-422: Appropriate grouping of crypto commands for common component options.Including the new crypto commands in the existing component options group maintains consistency across the CLI.
427-428: Updated timeout default to use the new constant.Using the
DEFAULT_API_TIMEOUTconstant provides consistency and makes it easier to update timeouts across the application.
651-653: Good addition of crypto commands to output options.This ensures the new crypto commands have consistent output handling with the rest of the application.
776-778: Appropriate inclusion of crypto commands in global GRPC options.This maintains consistency across all commands that use gRPC functionality.
833-835: Good addition of crypto commands to the help/trace options.This ensures consistent debug and tracing capabilities across all commands.
src/scanoss/cryptography.py (11)
11-12: Good practice to create a custom exception class.Creating a dedicated exception class for cryptography-related errors allows for more specific error handling and improves code clarity.
27-37: Clean config creation from CLI arguments.The function effectively extracts configuration from CLI arguments using
getattrwith default values to handle missing attributes.
40-74: Well-organized class initialization.The
Cryptographyclass is properly initialized with dependencies injected, following good software design principles. It creates its ownScanossBaseandCryptographyPresenterinstances and stores the provided configuration and client.
76-96: Good implementation of get_algorithms method.The method properly checks for missing purls, logs the operation, calls the appropriate gRPC method based on configuration, and handles the response.
98-120: Good implementation of get_encryption_hints method.Similar to
get_algorithms, this method validates inputs, logs actions, calls the correct gRPC method, and handles the response appropriately.
122-141: Good implementation of get_versions_in_range method.Following the pattern of the other methods, this implementation properly validates, logs, and handles the gRPC call.
174-176: Clean presentation method.The
presentmethod provides a simple interface to the presenter, delegating all formatting details.
179-188: Good presenter class design.The
CryptographyPresenterclass properly inherits fromAbstractPresenterand takes the cryptography instance in its constructor, following good OOP practices.
189-196: Simple and effective JSON output formatting.The method directly uses
json.dumpswith proper indentation, which is appropriate for JSON formatting.
198-206: Good plain text output formatting with type checking.The method handles both dictionary and non-dictionary results appropriately.
208-218: Clear indication of unimplemented output formats.Using
NotImplementedErrorwith descriptive messages is a good way to indicate that these output formats are not yet supported.
src/scanoss/cryptography.py
Outdated
| @dataclass | ||
| class CryptographyConfig: | ||
| debug: bool = False | ||
| trace: bool = False | ||
| quiet: bool = False | ||
| with_range: bool = False | ||
| purl: List[str] = None | ||
| input_file: str = None | ||
| output_file: str = None | ||
| header: str = None |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Well-structured configuration dataclass.
The CryptographyConfig class effectively encapsulates all configuration options needed for the cryptography functionality. However, there's an issue with the type of the purl field.
The purl field is defined as List[str] but isn't handled correctly in _build_purls_request. This can cause issues if a single string is provided:
- purl: List[str] = None
+ purl: Optional[List[str]] = NoneThis should also be complemented with proper type handling in the _build_purls_request method.
Committable suggestion skipped: line range outside the PR's diff.
src/scanoss/cryptography.py
Outdated
| input_file_validation = validate_json_file(self.config.input_file) | ||
| if not input_file_validation.is_valid: | ||
| raise Exception(f'There was a problem with the purl input file. {input_file_validation.error}') |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve exception handling in file validation.
Using a generic Exception with a hardcoded message obscures the actual error.
Use a more specific exception type and preserve the original exception details:
- raise Exception(f'There was a problem with the purl input file. {input_file_validation.error}')
+ raise ScanossCryptographyError(f'There was a problem with the purl input file: {input_file_validation.error}')📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| input_file_validation = validate_json_file(self.config.input_file) | |
| if not input_file_validation.is_valid: | |
| raise Exception(f'There was a problem with the purl input file. {input_file_validation.error}') | |
| input_file_validation = validate_json_file(self.config.input_file) | |
| if not input_file_validation.is_valid: | |
| - raise Exception(f'There was a problem with the purl input file. {input_file_validation.error}') | |
| + raise ScanossCryptographyError( | |
| + f'There was a problem with the purl input file: {input_file_validation.error}' | |
| + ) |
src/scanoss/cryptography.py
Outdated
| ): | ||
| raise Exception('The supplied input file is not in the correct PurlRequest format.') |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve exception handling for format validation.
Similar to the previous issue, using a generic Exception with a hardcoded message isn't ideal.
Use the custom exception class for better error handling:
- raise Exception('The supplied input file is not in the correct PurlRequest format.')
+ raise ScanossCryptographyError('The supplied input file is not in the correct PurlRequest format.')📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ): | |
| raise Exception('The supplied input file is not in the correct PurlRequest format.') | |
| ): | |
| raise ScanossCryptographyError('The supplied input file is not in the correct PurlRequest format.') |
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/scanoss/cli.py (1)
1467-1506: 💡 Verification agent🧩 Analysis chain
Good implementation of crypto_algorithms command handler.
The function properly validates inputs, checks certificate existence, and creates the necessary configurations to execute the command. The error handling is appropriate, capturing both specific gRPC errors and general exceptions.
However, there's a TODO comment about PAC file support that should be addressed.
Please consider implementing the PAC file support or provide a timeline for when this will be addressed:
🏁 Script executed:
#!/bin/bash # Check for similar PAC file implementations in other handlers grep -A 3 "pac_file = get_pac_file" src/scanoss/cli.pyLength of output: 1414
Add PAC file support to
crypto_algorithmshandlerThe
crypto_algorithmssubcommand currently skips proxy configuration, even though other commands insrc/scanoss/cli.pyalready handle PAC files. Please align this handler with the existing patterns:
- Retrieve the PAC file at the start of the handler:
pac_file = get_pac_file(args.pac) if pac_file is None: print_stderr(f'No proxy configuration for: {args.pac}') sys.exit(1)- Pass
pac_filethrough your gRPC client or intoCryptography(via its config) so that all outgoing calls respect the proxy.- Remove the
# TODO: Add PAC file supportplaceholder once implemented.Example diff:
--- a/src/scanoss/cli.py +++ b/src/scanoss/cli.py @@ def crypto_algorithms(parser, args): - # TODO: Add PAC file support - # pac_file = get_pac_file(config.pac) + # Load PAC file for proxy configuration + pac_file = get_pac_file(args.pac) + if pac_file is None: + print_stderr(f'No proxy configuration for: {args.pac}') + sys.exit(1) + cryptography = Cryptography(config=config, client=client)[src/scanoss/cli.py lines 1467–1506]
♻️ Duplicate comments (2)
src/scanoss/cli.py (2)
1508-1547: Good implementation of crypto_hints command handler.Similar to the algorithms handler, this function validates inputs, creates configurations, and handles errors appropriately. It also has the same issue with PAC file support being marked as a TODO.
1549-1587: Good implementation of crypto_versions_in_range command handler.Like the other crypto command handlers, this function properly validates inputs, creates configurations, and handles errors. It also has the same issue with PAC file support.
🧹 Nitpick comments (1)
CHANGELOG.md (1)
12-17: CHANGELOG properly updated with new version and features.The entry correctly documents the new functionality added in version 1.24.0, with clear descriptions of each new crypto sub-command.
Minor grammatical improvement suggestion: Consider standardizing the wording to avoid repetition of "Add".
## [1.24.0] - 2025-05-06 ### Added - Add `crypto` subcommand to retrieve cryptographic algorithms for the given components - Add `crypto hints` subcommand to retrieve cryptographic hints for the given components - Add `crypto versions-in-range` subcommand to retrieve cryptographic versions in range for the given componentsCould be improved to:
## [1.24.0] - 2025-05-06 ### Added - New `crypto` subcommand to retrieve cryptographic algorithms for the given components - New `crypto hints` subcommand to retrieve cryptographic hints for the given components - New `crypto versions-in-range` subcommand to retrieve cryptographic versions in range for the given components🧰 Tools
🪛 LanguageTool
[grammar] ~13-~13: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...hanges... ## [1.24.0] - 2025-05-06 ### Added - Addcryptosubcommand to retrieve cryptog...(REPEATED_VERBS)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CHANGELOG.md(2 hunks)docs/source/index.rst(1 hunks)src/scanoss/__init__.py(1 hunks)src/scanoss/cli.py(10 hunks)
✅ Files skipped from review due to trivial changes (2)
- src/scanoss/init.py
- docs/source/index.rst
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[grammar] ~13-~13: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...hanges... ## [1.24.0] - 2025-05-06 ### Added - Add crypto subcommand to retrieve cryptog...
(REPEATED_VERBS)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (5)
src/scanoss/cli.py (4)
34-34: Good import of the new cryptography module.The import statement correctly references the new Cryptography class and its configuration helper function, which will be used by the new command handlers.
357-405: Well-structured implementation of the new crypto command hierarchy.The command structure follows the established pattern used for other command groups in the codebase:
- Main 'crypto' command with appropriate aliases
- Logical sub-commands with clear descriptions
- The '--with-range' flag is properly implemented where needed
- Clear help messages that explain the purpose of each command
407-421: Good integration with existing CLI infrastructure.The new crypto commands are properly integrated into all the necessary command groups to inherit common CLI options, including output options, API options, GRPC options, and help/trace options.
Also applies to: 650-652, 737-739, 775-778, 832-834
848-849: Proper inclusion of the new crypto command in the sub-command verification.The condition correctly includes 'crypto' and its alias 'cr' when checking if a sub-command is required.
CHANGELOG.md (1)
524-525: Correctly added version comparison link.The link to compare changes between versions 1.23.0 and 1.24.0 is correctly formatted and included at the end of the file.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/scanoss/cli.py (1)
1467-1590: Consider refactoring common code in crypto handlers.The three crypto handler functions share very similar structure and logic. Consider refactoring the common parts into a helper function to improve maintainability and reduce code duplication.
+ def _handle_crypto_command(parser, args, command_func, command_name): + """ + Common handler function for crypto commands + Parameters + ---------- + parser: ArgumentParser + command line parser object + args: Namespace + Parsed arguments + command_func: Callable + The Cryptography method to call + command_name: str + Name of the command for error messages + """ + if (not args.purl and not args.input) or (args.purl and args.input): + print_stderr('Please specify an input file or purl to decorate (--purl or --input)') + parser.parse_args([args.subparser, args.subparsercmd, '-h']) + sys.exit(1) + if args.ca_cert and not os.path.exists(args.ca_cert): + print_stderr(f'Error: Certificate file does not exist: {args.ca_cert}.') + sys.exit(1) + + try: + config = create_cryptography_config_from_args(args) + grpc_config = create_grpc_config_from_args(args) + if args.pac: + grpc_config.pac = get_pac_file(args.pac) + if args.header: + grpc_config.req_headers = process_req_headers(args.header) + client = ScanossGrpc(**asdict(grpc_config)) + + cryptography = Cryptography(config=config, client=client) + command_func(cryptography) + cryptography.present(output_file=args.output) + except ScanossGrpcError as e: + print_stderr(f'API ERROR: {e}') + sys.exit(1) + except Exception as e: + if args.debug: + import traceback + + traceback.print_exc() + print_stderr(f'ERROR: {e}') + sys.exit(1) + + def crypto_algorithms(parser, args): + """ + Run the "crypto algorithms" sub-command + Parameters + ---------- + parser: ArgumentParser + command line parser object + args: Namespace + Parsed arguments + """ + _handle_crypto_command(parser, args, lambda crypto: crypto.get_algorithms(), "algorithms") + + def crypto_hints(parser, args): + """ + Run the "crypto hints" sub-command + Parameters + ---------- + parser: ArgumentParser + command line parser object + args: Namespace + Parsed arguments + """ + _handle_crypto_command(parser, args, lambda crypto: crypto.get_encryption_hints(), "hints") + + def crypto_versions_in_range(parser, args): + """ + Run the "crypto versions-in-range" sub-command + Parameters + ---------- + parser: ArgumentParser + command line parser object + args: Namespace + Parsed arguments + """ + _handle_crypto_command(parser, args, lambda crypto: crypto.get_versions_in_range(), "versions-in-range")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/scanoss/cli.py(10 hunks)src/scanoss/scanossgrpc.py(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
src/scanoss/scanossgrpc.py (1)
src/scanoss/api/cryptography/v2/scanoss_cryptography_pb2_grpc.py (10)
GetAlgorithms(64-69)GetAlgorithms(162-176)GetAlgorithmsInRange(71-76)GetAlgorithmsInRange(179-193)GetEncryptionHints(92-97)GetEncryptionHints(230-244)GetHintsInRange(85-90)GetHintsInRange(213-227)GetVersionsInRange(78-83)GetVersionsInRange(196-210)
src/scanoss/cli.py (3)
src/scanoss/cryptography.py (6)
Cryptography(40-176)create_cryptography_config_from_args(27-37)get_algorithms(76-96)present(174-176)get_encryption_hints(98-120)get_versions_in_range(122-141)src/scanoss/scanossgrpc.py (3)
create_grpc_config_from_args(701-713)ScanossGrpc(94-677)ScanossGrpcError(77-82)src/scanoss/scanossbase.py (1)
print_stderr(45-49)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (10)
src/scanoss/scanossgrpc.py (6)
579-594: Well-implemented crypto algorithm query method.This method follows the established pattern of using
_call_rpchelper for gRPC calls, making the code more maintainable and consistent with other methods in the class.
596-611: Good implementation of algorithms in range query method.The method properly uses the internal
_call_rpchelper with appropriate parameters and error handling. The docstring clearly describes its purpose and return values.
613-628: Encryption hints query method looks good.This implements the client function for calling the
GetEncryptionHintsRPC in a consistent manner with other methods, using the shared_call_rpchelper.
630-645: Encryption hints in range query method is well-implemented.The method uses the same pattern as other crypto methods, ensuring a consistent API for the client code.
647-662: Versions in range query method looks correct.This method follows the established pattern for gRPC client methods, with appropriate error handling via the
_call_rpchelper method.
697-698: Fields reordered in GrpcConfig dataclass.The
pacandreq_headersfields have been reordered. This is a minor change that maintains the functionality while aligning with the updated code structure.src/scanoss/cli.py (4)
357-405: Well-structured crypto command group with appropriate subcommands.The implementation adds a new top-level
cryptocommand with three nested subcommands:algorithms,hints, andversions-in-range. Each has appropriate aliases and descriptive help text. The implementation follows the same pattern as other command groups in the codebase.
1467-1507: Good implementation of crypto_algorithms command handler.The handler correctly:
- Validates input parameters
- Checks certificate files
- Creates appropriate configurations
- Sets up gRPC client with proxy and header handling
- Initializes the Cryptography class
- Performs the API call and presents results
- Handles both specific ScanossGrpcError and general exceptions
1509-1549: Good implementation of crypto_hints command handler.The function correctly validates inputs, creates configurations, and handles errors appropriately, following the same pattern as the algorithms handler. The PAC file support is properly implemented.
1551-1590: Good implementation of crypto_versions_in_range command handler.Like the other crypto command handlers, this function properly validates inputs, creates configurations, and handles errors. The implementation is consistent with the other crypto handlers.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (4)
src/scanoss/cryptography.py (4)
40-42: 🛠️ Refactor suggestionUse custom exception class instead of generic Exception
The class defines a custom
ScanossCryptographyErrorexception but doesn't use it consistently throughout the code. Using generic exceptions with hardcoded error messages obscures the root cause.- raise Exception( - f'There was a problem with the purl input file. {input_file_validation.error}' - ) + raise ScanossCryptographyError( + f'There was a problem with the purl input file: {input_file_validation.error}' + )
54-56: 🛠️ Refactor suggestionUse custom exception class for format validation errors
For consistency, use the custom
ScanossCryptographyErrorexception instead ofValueError.- raise ValueError( - 'The supplied input file is not in the correct PurlRequest format.' - ) + raise ScanossCryptographyError( + 'The supplied input file is not in the correct PurlRequest format.' + )
214-216: 🛠️ Refactor suggestionUse custom exception class and preserve original error details
Use the custom exception class consistently and preserve the original error information.
- raise Exception( - f'There was a problem with the purl input file. {input_file_validation.error}' - ) + raise ScanossCryptographyError( + f'There was a problem with the purl input file: {input_file_validation.error}' + )
219-229: 🛠️ Refactor suggestionHandle potential
Nonevalue forself.config.purlThe code currently assumes
self.config.purlis neverNone, but the previous comments suggest it should be made optional. Ensure proper handling ofNonevalues.if self.config.purl: return { 'purls': [ { 'purl': p, 'requirement': self._extract_version_from_purl(p), } for p in self.config.purl ] }This code handles
Nonecorrectly but would need to be updated if you change the type toOptional[List[str]]to also handle ifself.config.purlis a single string rather than a list.
🧹 Nitpick comments (4)
src/scanoss/cryptography.py (4)
32-32: Replace magic value with a named constantUsing a magic value in comparison reduces code readability and maintainability.
+ # Minimum number of parts expected when splitting a PURL by '@' + MIN_PURL_PARTS = 2 - if not (len(parts) >= 2 and parts[1]): + if not (len(parts) >= MIN_PURL_PARTS and parts[1]):This change addresses the static analysis warning PLR2004 and improves code readability.
🧰 Tools
🪛 Ruff (0.8.2)
32-32: Magic value used in comparison, consider replacing
2with a constant variable(PLR2004)
🪛 GitHub Actions: Lint
[warning] 32-32: PLR2004 Magic value used in comparison, consider replacing
2with a constant variable
201-210: Update docstring to match method signatureThe docstring for
_build_purls_requestreferences parameters that don't exist in the method signature.- """ - Load the specified purls from a JSON file or a list of PURLs and return a dictionary - - Args: - json_file (Optional[str], optional): The JSON file containing the PURLs. Defaults to None. - purls (Optional[List[str]], optional): The list of PURLs. Defaults to None. - - Returns: - Optional[dict]: The dictionary containing the PURLs - """ + """ + Build a purls request dictionary from either the input file or the list of purls + in the configuration. + + Returns: + Optional[dict]: The dictionary containing the PURLs formatted for the API request, + or None if no purls are available. + """
246-247: Improve error handling for version extractionThe error handling for version extraction from PURL could be improved by using the custom exception class and providing more context.
try: return purl.split('@')[-1] except IndexError: - raise ValueError(f'Invalid purl format: {purl}') + raise ScanossCryptographyError( + f'Invalid purl format: {purl}. A valid purl must include a version (e.g., pkg:type/name@version)' + )
284-287: Improve plain text output formattingThe plain text output is identical to the JSON output when results are a dictionary. Consider creating a truly plain-text representation that's more human-readable.
- return ( - json.dumps(self.cryptography.results, indent=2) - if isinstance(self.cryptography.results, dict) - else str(self.cryptography.results) - ) + """ + Format the scan output data into a plain text string + """ + if not self.cryptography.results: + return "No results available." + + if isinstance(self.cryptography.results, dict): + # Create a more readable plain text representation + output = [] + + # Example formatting for algorithms data + if "algorithms" in self.cryptography.results: + output.append("CRYPTOGRAPHIC ALGORITHMS:") + for algo_data in self.cryptography.results["algorithms"]: + purl = algo_data.get("purl", "Unknown PURL") + output.append(f"\n{purl}") + + if "algorithms" in algo_data: + for algo in algo_data["algorithms"]: + output.append(f" - {algo.get('name', 'Unknown')} ({algo.get('type', 'Unknown type')})") + + # Add similar formatting for other result types + + return "\n".join(output) + else: + return str(self.cryptography.results)Note: The exact implementation would depend on the structure of the results for different API calls.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/scanoss/cryptography.py(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/scanoss/cryptography.py (5)
src/scanoss/scanossbase.py (1)
ScanossBase(28-107)src/scanoss/scanossgrpc.py (5)
get_crypto_algorithms_in_range_for_purl(596-611)get_crypto_algorithms_for_purl(579-594)get_encryption_hints_in_range_for_purl(630-645)get_encryption_hints_for_purl(613-628)get_versions_in_range_for_purl(647-662)src/scanoss/utils/abstract_presenter.py (1)
AbstractPresenter(6-103)src/scanoss/utils/file.py (1)
validate_json_file(44-84)src/scanoss/cli.py (1)
print_stderr(80-84)
🪛 Ruff (0.8.2)
src/scanoss/cryptography.py
32-32: Magic value used in comparison, consider replacing 2 with a constant variable
(PLR2004)
🪛 GitHub Actions: Lint
src/scanoss/cryptography.py
[warning] 32-32: PLR2004 Magic value used in comparison, consider replacing 2 with a constant variable
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (1)
src/scanoss/cryptography.py (1)
17-17:❌ Incorrect review comment
Ensure
purlfield is properly handled as optionalThe
purlfield is declared as a non-optionalList[str]without a default value, which differs from other optional parameters that explicitly set defaults toNone. This could cause initialization issues if no purls are provided.- purl: List[str] + purl: Optional[List[str]] = NoneThis change would make the field's optionality explicit and consistent with how it's handled in the error checks on lines 123-126, 151-154, and 181-184.
🏁 Script executed:
#!/bin/bash grep -R -n "purl" src/scanoss/cryptography.pyLength of output: 3258
🏁 Script executed:
#!/bin/bash sed -n '1,200p' src/scanoss/cryptography.pyLength of output: 6737
🏁 Script executed:
#!/bin/bash sed -n '190,260p' src/scanoss/cryptography.pyLength of output: 2223
Ignore optionality change for
purlThe
purlfield is always supplied bycreate_cryptography_config_from_args(it defaults to an empty list if no--purlis given), so it can never be uninitialized at runtime. Making itOptional[List[str]] = Noneisn’t necessary and would complicate the existing default logic. If you did want a default built in at the dataclass level, the more idiomatic approach is:from dataclasses import field @dataclass class CryptographyConfig: purl: List[str] = field(default_factory=list) # …The current setup correctly triggers a “No PURLs supplied. Provide --purl or --input.” error when both
purlandinput_fileare empty.Likely an incorrect or invalid review comment.
| raise ValueError( | ||
| 'One or more PURLs are missing the "requirement" field.' | ||
| ) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Use custom exception class for requirement field errors
For consistency, use the custom ScanossCryptographyError exception here as well.
- raise ValueError(
- 'One or more PURLs are missing the "requirement" field.'
- )
+ raise ScanossCryptographyError(
+ 'One or more PURLs are missing the "requirement" field.'
+ )📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| raise ValueError( | |
| 'One or more PURLs are missing the "requirement" field.' | |
| ) | |
| raise ScanossCryptographyError( | |
| 'One or more PURLs are missing the "requirement" field.' | |
| ) |
| if self.config.input_file: | ||
| input_file_validation = validate_json_file(self.config.input_file) | ||
| if not input_file_validation.is_valid: | ||
| raise Exception( | ||
| f'There was a problem with the purl input file. {input_file_validation.error}' | ||
| ) | ||
|
|
||
| return input_file_validation.data |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Eliminate code duplication in file validation logic
The input file validation logic is duplicated between __post_init__ and _build_purls_request.
Consider extracting the validation logic into a separate helper method:
+ def _validate_input_file(self, input_file: str) -> dict:
+ """
+ Validate the input file and return the parsed data.
+
+ Args:
+ input_file (str): Path to the input file
+
+ Returns:
+ dict: The parsed data from the input file
+
+ Raises:
+ ScanossCryptographyError: If the input file is invalid
+ """
+ input_file_validation = validate_json_file(input_file)
+ if not input_file_validation.is_valid:
+ raise ScanossCryptographyError(
+ f'There was a problem with the purl input file: {input_file_validation.error}'
+ )
+ return input_file_validation.data
+
def _build_purls_request(
self,
) -> Optional[dict]:
"""
Build a purls request dictionary from either the input file or the list of purls
in the configuration.
Returns:
Optional[dict]: The dictionary containing the PURLs formatted for the API request,
or None if no purls are available.
"""
if self.config.input_file:
- input_file_validation = validate_json_file(self.config.input_file)
- if not input_file_validation.is_valid:
- raise Exception(
- f'There was a problem with the purl input file. {input_file_validation.error}'
- )
-
- return input_file_validation.data
+ return self._validate_input_file(self.config.input_file)Then update the __post_init__ method to use this helper method as well.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if self.config.input_file: | |
| input_file_validation = validate_json_file(self.config.input_file) | |
| if not input_file_validation.is_valid: | |
| raise Exception( | |
| f'There was a problem with the purl input file. {input_file_validation.error}' | |
| ) | |
| return input_file_validation.data | |
| def _validate_input_file(self, input_file: str) -> dict: | |
| """ | |
| Validate the input file and return the parsed data. | |
| Args: | |
| input_file (str): Path to the input file | |
| Returns: | |
| dict: The parsed data from the input file | |
| Raises: | |
| ScanossCryptographyError: If the input file is invalid | |
| """ | |
| input_file_validation = validate_json_file(input_file) | |
| if not input_file_validation.is_valid: | |
| raise ScanossCryptographyError( | |
| f'There was a problem with the purl input file: {input_file_validation.error}' | |
| ) | |
| return input_file_validation.data | |
| def _build_purls_request( | |
| self, | |
| ) -> Optional[dict]: | |
| """ | |
| Build a purls request dictionary from either the input file or the list of purls | |
| in the configuration. | |
| Returns: | |
| Optional[dict]: The dictionary containing the PURLs formatted for the API request, | |
| or None if no purls are available. | |
| """ | |
| if self.config.input_file: | |
| return self._validate_input_file(self.config.input_file) | |
| # ... existing logic for self.config.purl ... |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
src/scanoss/cryptography.py (4)
63-65: Use custom exception class for requirement field errorsFor consistency with the module's error handling approach, use the custom
ScanossCryptographyErrorexception instead of a genericValueError.- raise ValueError( + raise ScanossCryptographyError( 'One or more PURLs are missing the "requirement" field.' )
217-219: 🛠️ Refactor suggestionUse custom exception class for file validation errors
Replace the generic
Exceptionwith the customScanossCryptographyErrorfor consistency with the rest of the module and better error handling.- raise Exception( + raise ScanossCryptographyError( f'There was a problem with the purl input file. {input_file_validation.error}' )
42-45: 🛠️ Refactor suggestionUse custom exception class for input file validation errors
The code is using a generic
Exceptionwith a hardcoded message. For consistency with the rest of the module and better error handling, use the customScanossCryptographyErrorclass you've defined.- raise Exception( + raise ScanossCryptographyError( f'There was a problem with the purl input file. {input_file_validation.error}' )
214-221: 🛠️ Refactor suggestionEliminate code duplication in file validation logic
The input file validation logic is duplicated between
__post_init__and_build_purls_request. Extract this into a separate helper method to avoid duplication and ensure consistent validation.+ def _validate_input_file(self, input_file: str) -> dict: + """ + Validate the input file and return the parsed data. + + Args: + input_file (str): Path to the input file + + Returns: + dict: The parsed data from the input file + + Raises: + ScanossCryptographyError: If the input file is invalid + """ + input_file_validation = validate_json_file(input_file) + if not input_file_validation.is_valid: + raise ScanossCryptographyError( + f'There was a problem with the purl input file: {input_file_validation.error}' + ) + return input_file_validation.data + def _build_purls_request( self, ) -> Optional[dict]: """ Load the specified purls from a JSON file or a list of PURLs and return a dictionary Args: json_file (Optional[str], optional): The JSON file containing the PURLs. Defaults to None. purls (Optional[List[str]], optional): The list of PURLs. Defaults to None. Returns: Optional[dict]: The dictionary containing the PURLs """ if self.config.input_file: - input_file_validation = validate_json_file(self.config.input_file) - if not input_file_validation.is_valid: - raise Exception( - f'There was a problem with the purl input file. {input_file_validation.error}' - ) - - return input_file_validation.data + return self._validate_input_file(self.config.input_file)Then update the
__post_init__method to use this helper method as well.
🧹 Nitpick comments (3)
src/scanoss/cryptography.py (3)
223-231: Conditionally include requirement field based on with_range settingThe code always extracts and includes the version requirement from PURLs, even when
with_rangeis False. This might lead to unnecessary processing or confusion. Consider conditionally including the requirement field only when it's needed.if self.config.purl: + purls_dict = {'purls': []} + for p in self.config.purl: + purl_entry = {'purl': p} + if self.config.with_range: + purl_entry['requirement'] = self._extract_version_from_purl(p) + purls_dict['purls'].append(purl_entry) + return purls_dict - return { - 'purls': [ - { - 'purl': p, - 'requirement': self._extract_version_from_purl(p), - } - for p in self.config.purl - ] - }
248-250: Improve error handling in version extractionThe current implementation catches IndexError but it's unclear when this would occur since
.split()always returns at least one item. Also, the error message doesn't provide actionable guidance.def _extract_version_from_purl(self, purl: str) -> str: """ Extract version from purl Args: purl (str): The purl string to extract the version from Returns: str: The extracted version Raises: ValueError: If the purl is not in the correct format """ try: - return purl.split('@')[-1] + parts = purl.split('@') + if len(parts) < 2 or not parts[1]: + raise ValueError( + f'Invalid PURL format: "{purl}". It must include a version (e.g., pkg:type/name@version)' + ) + return parts[1] except IndexError: - raise ValueError(f'Invalid purl format: {purl}') + # This should never happen with split(), but just in case + raise ValueError( + f'Invalid PURL format: "{purl}". It must include a version (e.g., pkg:type/name@version)' + )
282-290: Simplify _format_plain_output with conditional expressionThe implementation of
_format_plain_outputcan be simplified using a conditional expression rather than a multi-line return statement.def _format_plain_output(self) -> str: """ Format the scan output data into a plain text string """ - return ( - json.dumps(self.cryptography.results, indent=2) - if isinstance(self.cryptography.results, dict) - else str(self.cryptography.results) - ) + return json.dumps(self.cryptography.results, indent=2) if isinstance(self.cryptography.results, dict) else str(self.cryptography.results)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/scanoss/cryptography.py(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/scanoss/cryptography.py (5)
src/scanoss/scanossbase.py (1)
ScanossBase(28-107)src/scanoss/scanossgrpc.py (5)
get_crypto_algorithms_in_range_for_purl(596-611)get_crypto_algorithms_for_purl(579-594)get_encryption_hints_in_range_for_purl(630-645)get_encryption_hints_for_purl(613-628)get_versions_in_range_for_purl(647-662)src/scanoss/utils/abstract_presenter.py (1)
AbstractPresenter(6-103)src/scanoss/utils/file.py (1)
validate_json_file(44-84)src/scanoss/cli.py (1)
print_stderr(80-84)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (4)
src/scanoss/cryptography.py (4)
126-129: Consistent validation approach for missing PURLsGood implementation of early validation for missing PURLs using a custom exception, which was suggested in a previous review.
292-302: Good use of NotImplementedError for unimplemented format methodsThe implementation correctly raises
NotImplementedErrorfor output formats that aren't supported yet, following the contract defined in theAbstractPresenterclass. This is a good practice to clearly indicate methods that need implementation.
66-66: 🛠️ Refactor suggestionRemove unnecessary return statement in post_init
The
__post_init__method is called automatically after object initialization and shouldn't return a value as it won't be used anywhere. Remove this return statement.- return input_file_validation.dataLikely an incorrect or invalid review comment.
222-232:❌ Incorrect review comment
Consider type safety when building the request from purls
The
purlfield inCryptographyConfigis declared asList[str], but there's no typecasting to ensure it's always a list. If a single string was incorrectly passed (e.g., due to a missing comma in CLI), each character might be treated as a separate PURL.Verify that the
purlfield is always a list by adding a check and typecasting:
🏁 Script executed:
#!/bin/bash # Search for usages of the purl field in the codebase rg "self\.config\.purl" --include "*.py" -A 2 -B 2Length of output: 494
Let’s rerun the searches without the unsupported
--includeflag and also locate whereCryptographyConfigand the CLI--purlargument are defined:#!/bin/bash # 1. Search for usages of self.config.purl rg "self\\.config\\.purl" # 2. Locate the CryptographyConfig class rg "class CryptographyConfig" -n . # 3. If found, show lines defining the purl field CONFIG_FILE=$(rg "class CryptographyConfig" -l . | head -n1) if [[ -n "$CONFIG_FILE" ]]; then echo "purl in $CONFIG_FILE:" grep -n "purl" "$CONFIG_FILE" fi # 4. Find the CLI parser definition for --purl rg "add_argument.*--purl" -n .
Let’s broaden our search for any
purloccurrences, locate theCryptographyConfigdefinition, and inspect the CLI parser setup:
🏁 Script executed:
#!/bin/bash # 1. Search globally for any 'purl' references echo "=== All 'purl' occurrences ===" rg -n "purl" # 2. Locate the CryptographyConfig class file CONFIG_FILE=$(rg -l "class CryptographyConfig" | head -n1) if [[ -n "$CONFIG_FILE" ]]; then echo "=== Inspecting $CONFIG_FILE for purl field ===" sed -n '1,200p' "$CONFIG_FILE" | rg -n "purl" else echo "CryptographyConfig class not found." fi # 3. Find the CLI parser definition for --purl echo "=== CLI parser definitions for --purl ===" rg -n "add_argument.*--purl"Length of output: 63442
To confirm that
self.config.purlis always a list in the Cryptography commands, let’s inspect:#!/bin/bash # 1. Show the CLI subparser for cryptography to verify purl’s argparse configuration echo "=== CLI around cryptography (lines 340–430) ===" sed -n '340,430p' src/scanoss/cli.py # 2. Show how CryptographyConfig is defined and how _build_purls_request uses self.config.purl echo "=== CryptographyConfig & _build_purls_request (lines 1–120 & 180–260) ===" sed -n '1,120p' src/scanoss/cryptography.py sed -n '180,260p' src/scanoss/cryptography.py
No type‐safety change required for
purlin CryptographyConfig
The--purloption in the Crypto commands is defined withnargs='*', soargs.purlwill always be aList[str](orNonewhen not used, which is correctly handled by the input‐vs‐purl logic). There is no scenario where a lone string would be iterated character‐by‐character in_build_purls_request, so no additional typecasting is needed.Likely an incorrect or invalid review comment.
Summary by CodeRabbit
New Features
Improvements
Other Changes