MM-34714 fix mention highlight to dismiss mentions for non existent u…

…sers (mattermost#5300)
scheissegalo · Apr 10, 2021 · 06f8f0b · 06f8f0b
1 parent c22e93d
commit 06f8f0b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/app/components/at_mention/__snapshots__/at_mention.test.js.snap b/app/components/at_mention/__snapshots__/at_mention.test.js.snap
@@ -9,14 +9,7 @@ exports[`AtMention should match snapshot, no highlight 1`] = `
   }
 >
   <Text
-    style={
-      Array [
-        Object {
-          "backgroundColor": "#ffe577",
-          "color": "#145dbf",
-        },
-      ]
-    }
+    style={Array []}
   >
     @John.Smith
   </Text>

diff --git a/app/components/at_mention/at_mention.js b/app/components/at_mention/at_mention.js
@@ -174,12 +174,12 @@ export default class AtMention extends React.PureComponent {
             } else {
                 const pattern = new RegExp(/\b(all|channel|here)(?:\.\B|_\b|\b)/, 'i');
                 const mentionMatch = pattern.exec(mentionName);
-                highlighted = true;
 
                 if (mentionMatch) {
                     mention = mentionMatch.length > 1 ? mentionMatch[1] : mentionMatch[0];
                     suffix = mentionName.replace(mention, '');
                     isMention = true;
+                    highlighted = true;
                 } else {
                     mention = mentionName;
                 }