VAN: Fix codes bugs. (move-coop#696)

* Fix request name. * Fix changed entities bugs. * Added test.
schlich · Jun 7, 2022 · 8411c21 · 8411c21
1 parent 4395479
commit 8411c21
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/parsons/ngpvan/codes.py b/parsons/ngpvan/codes.py
@@ -53,7 +53,7 @@ def get_code(self, code_id):
                 See :ref:`parsons-table` for output options.
         """
 
-        c = self.connection.request(f'codes/{code_id}')
+        c = self.connection.get_request(f'codes/{code_id}')
         logger.debug(c)
         logger.info(f'Found code {code_id}.')
         return c
@@ -115,7 +115,7 @@ def create_code(self, name=None, parent_code_id=None, description=None,
 
             se = [{'name': s['name'],
                    'isSearchable': s['is_searchable'],
-                   'is_applicable': s['is_applicable']} for s in supported_entities]
+                   'isApplicable': s['is_applicable']} for s in supported_entities]
 
             json['supportedEntities'] = se
 
@@ -175,7 +175,7 @@ def update_code(self, code_id, name=None, parent_code_id=None, description=None,
 
             se = [{'name': s['name'],
                    'isSearchable': s['is_searchable'],
-                   'is_applicable': s['is_applicable']} for s in supported_entities]
+                   'isApplicable': s['is_applicable']} for s in supported_entities]
             post_data['supportedEntities'] = se
 
         r = self.connection.put_request(f'codes/{code_id}', json=post_data)

diff --git a/test/test_van/test_codes.py b/test/test_van/test_codes.py
@@ -37,6 +37,24 @@ def test_get_codes(self, m):
         m.get(self.van.connection.uri + 'codes', json=json)
         assert_matching_tables(json['items'], self.van.get_codes())
 
+    @requests_mock.Mocker()
+    def test_get_code(self, m):
+
+        json = {'codeId': 1004916,
+                'parentCodeId': None,
+                'name': 'Data Entry',
+                'description': 'for test.',
+                'codePath': 'Data Entry',
+                'createdByName': '',
+                'dateCreated': '2018-07-13T15:16:00Z',
+                'supportedEntities': None,
+                'codeType': 'Tag',
+                'campaign': None,
+                'contactType': None}
+
+        m.get(self.van.connection.uri + 'codes/1004916', json=json)
+        self.assertEqual(json, self.van.get_code(1004916))
+
     @requests_mock.Mocker()
     def test_get_code_types(self, m):