Enable inheriting from Parser without re-specifying @default options

See: inukshuk#174 (comment)
scholarcy · Nov 28, 2021 · 60c68de · 60c68de
1 parent 300df33
commit 60c68de
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/anystyle/parser.rb b/lib/anystyle/parser.rb
@@ -18,7 +18,8 @@ def instance
     attr_reader :model, :options, :features, :normalizers, :mtime
 
     def initialize(options = {})
-      @options = self.class.defaults.merge(options)
+      def_opts = self.class.defaults || Parser.defaults
+      @options = def_opts.merge(options)
       load_model
     end
 

diff --git a/spec/anystyle/parser_spec.rb b/spec/anystyle/parser_spec.rb
@@ -119,5 +119,12 @@ module AnyStyle
         end
       end
     end
+    describe "Inheritance" do
+      class ParserSubclass < AnyStyle::Parser
+      end
+      it 'Subclass can be initialized without own @defaults' do
+        expect { ParserSubclass.new }.not_to raise_error
+      end
+    end
   end
 end