Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add QC to Bundle/recognize module #114

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] Add QC to Bundle/recognize module #114

wants to merge 5 commits into from

Conversation

Manonedde
Copy link
Contributor

@Manonedde Manonedde commented Feb 25, 2025 •
edited
Loading

Add QC steps to bundle/reconize module.

Example of QC image :
image

@Manonedde Manonedde self-assigned this Feb 25, 2025
@Manonedde Manonedde added the qc label Feb 25, 2025
@Manonedde Manonedde linked an issue Feb 25, 2025 that may be closed by this pull request
Create MultiQC Proof of Concept #98
Closed
6 tasks
@Manonedde Manonedde changed the title Add QC to Bundle/recognize module [WIP] Add QC to Bundle/recognize module Feb 25, 2025
@gagnonanthony gagnonanthony mentioned this pull request Mar 4, 2025
Closed
6 tasks
@arnaudbore arnaudbore requested a review from gagnonanthony March 4, 2025 21:26
gagnonanthony
gagnonanthony requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!! 💯 Nothing to say to the code directly. However, while you are working with this module, could you also add the args to the meta.yml ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagnonanthony gagnonanthony gagnonanthony requested changes

@arnaudbore arnaudbore Awaiting requested review from arnaudbore

@ThoumyreStanislas ThoumyreStanislas Awaiting requested review from ThoumyreStanislas

Requested changes must be addressed to merge this pull request.

Assignees

@Manonedde Manonedde

Labels
qc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create MultiQC Proof of Concept
2 participants
@Manonedde @gagnonanthony