-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] add easyreg option to subworkflow/registration #215
base: main
Are you sure you want to change the base?
Conversation
de30e88
to
acda670
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work ! I think we can merge this fast after another round of review. My comments target syntax mostly. Also, some comments should move you forward to tests working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Some small comments from my side.
.map{ it + [[]] } | ||
transfo_trk = REGISTRATION_EASYREG.out.bak_field | ||
.map{ [[]] + it } | ||
ref_warped - REGISTRATION_EASYREG.out.ref_reg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this line is doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to ".map{ [[]] + it } or ref_warped output declaration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact it is not a = but a -. So I think you have a bug here.
bea6c73
to
f22cc49
Compare
Describe your changes
Add the synthbet option to preproc_t1
List test packages used by your module
processing.zip
Checklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf
./modules/nf-scil/<category>/<tool>/meta.yml
./tests/modules/nf-scil/<category>/<tool>/main.nf
./tests/modules/nf-scil/<category>/<tool>/nextflow.config
To Do
niftiMD5SUM
add conditionnal warpconvert