Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scilpy version - part 1 #1100

Merged
merged 12 commits into from
Jan 28, 2025
Merged

Add Scilpy version - part 1 #1100

merged 12 commits into from
Jan 28, 2025

Conversation

zinelya
Copy link
Contributor

@zinelya zinelya commented Dec 12, 2024

Fix issue #760

Part 1 of adding the Scilpy version to the scripts

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (d07a454) to head (b173dbf).
Report is 86 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
+ Coverage   69.45%   69.69%   +0.23%     
==========================================
  Files         448      449       +1     
  Lines       24096    24287     +191     
  Branches     3296     3323      +27     
==========================================
+ Hits        16737    16927     +190     
+ Misses       5963     5948      -15     
- Partials     1396     1412      +16     
Components Coverage Δ
Scripts 70.30% <100.00%> (+0.16%) ⬆️
Library 68.87% <100.00%> (+0.31%) ⬆️

Copy link
Contributor

@EmmaRenauld EmmaRenauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after my comment has been adressed

Copy link
Contributor

@karanphil karanphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I found a few things to adjust but it should be quick. Good to go after that!

scripts/scil_aodf_metrics.py Outdated Show resolved Hide resolved
scripts/scil_bundle_mean_fixel_afd_from_hdf5.py Outdated Show resolved Hide resolved
scripts/scil_bundle_shape_measures.py Outdated Show resolved Hide resolved
scripts/scil_connectivity_compute_pca.py Outdated Show resolved Hide resolved
scripts/scil_dwi_prepare_eddy_command.py Show resolved Hide resolved
Copy link
Contributor

@karanphil karanphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other comments!

scripts/scil_bundle_mean_fixel_afd.py Outdated Show resolved Hide resolved
scripts/scil_bundle_mean_fixel_afd.py Outdated Show resolved Hide resolved
@arnaudbore arnaudbore reopened this Jan 24, 2025
karanphil
karanphil previously approved these changes Jan 27, 2025
Copy link
Contributor

@karanphil karanphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comments and then GTG!

scripts/scil_aodf_metrics.py Outdated Show resolved Hide resolved
@arnaudbore arnaudbore enabled auto-merge January 27, 2025 22:13
Copy link
Contributor

@EmmaRenauld EmmaRenauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG!

@arnaudbore arnaudbore added this pull request to the merge queue Jan 28, 2025
Merged via the queue into scilus:master with commit 0d475e2 Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants