Update Checksum method

scmiot · Dec 13, 2021 · 438eb27 · 438eb27
1 parent 674c261
commit 438eb27
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/version/version.go b/version/version.go
@@ -3,6 +3,7 @@ package version
 import (
 	"crypto/sha1"
 	"crypto/sha256"
+	"encoding/hex"
 	"errors"
 	"fmt"
 	"hash"
@@ -201,7 +202,8 @@ func (pkg *Package) VerifyChecksum(filename string) (err error) {
 	if _, err := io.Copy(h, f); err != nil {
 		return err
 	}
-	if pkg.Checksum != fmt.Sprintf("%x", h.Sum(nil)) {
+
+	if pkg.Checksum != hex.EncodeToString(h.Sum(nil)) {
 		return ErrChecksumNotMatched
 	}
 	return nil

diff --git a/version/version_test.go b/version/version_test.go
@@ -3,6 +3,7 @@ package version
 import (
 	"crypto/sha1"
 	"crypto/sha256"
+	"encoding/hex"
 	"errors"
 	"fmt"
 	"io"
@@ -177,3 +178,24 @@ func TestVerifyChecksum(t *testing.T) {
 		})
 	})
 }
+
+var (
+	target = "2db6a5d25815b56072465a2cacc8ed426c18f1d5fc26c1fc8c4f5a7188658264"
+	source = []byte{45, 182, 165, 210, 88, 21, 181, 96, 114, 70, 90, 44, 172, 200, 237, 66, 108, 24, 241, 213, 252, 38, 193, 252, 140, 79, 90, 113, 136, 101, 130, 100}
+)
+
+func BenchmarkEqualHexFmt(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		if target == fmt.Sprintf("%x", source) {
+
+		}
+	}
+}
+
+func BenchmarkEqualHexEncodeToString(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		if target == hex.EncodeToString(source) {
+
+		}
+	}
+}