Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to run in docker #20

Merged
merged 7 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add option to run in docker
  • Loading branch information
scottlepp committed Oct 17, 2024
commit 1f6e6b81bca4b8c54a58e95fe53b68883048b25f
76 changes: 48 additions & 28 deletions duck/duckdb.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ type DuckDB struct {
chunk int
cacheDuration int
cache cache
docker bool
image string
}

type Opts struct {
Expand All @@ -36,9 +38,13 @@ type Opts struct {
Chunk int
Exe string
CacheDuration int
Docker bool
Image string
}

const newline = "\n"
const tempDir = "/var/folders/fv"
const duckdbImage = "datacatering/duckdb:v1.0.0"

// NewInMemoryDB creates a new in-memory DuckDB
func NewInMemoryDB(opts ...Opts) *DuckDB {
Expand Down Expand Up @@ -68,10 +74,15 @@ func NewDuckDB(name string, opts ...Opts) *DuckDB {
if opt.CacheDuration > 0 {
db.cacheDuration = opt.CacheDuration
}
db.image = duckdbImage
if opt.Image != "" {
db.image = opt.Image
}
db.docker = opt.Docker
}

// Find the executable if it is not configured
if db.exe == "" {
if db.exe == "" && !db.docker {
db.exe = which.Which("duckdb")
if db.exe == "" {
db.exe = "/usr/local/bin/duckdb"
Expand All @@ -83,33 +94,7 @@ func NewDuckDB(name string, opts ...Opts) *DuckDB {

// RunCommands runs a series of of sql commands against duckdb
func (d *DuckDB) RunCommands(commands []string) (string, error) {
var stdout bytes.Buffer
var stderr bytes.Buffer

var b bytes.Buffer
b.Write([]byte(fmt.Sprintf(".mode %s %s", d.mode, newline)))
for _, c := range commands {
cmd := fmt.Sprintf("%s %s", c, newline)
b.Write([]byte(cmd))
}

cmd := exec.Command(d.exe, d.Name)
cmd.Stdin = &b
cmd.Stdout = &stdout
cmd.Stderr = &stderr

err := cmd.Run()
if err != nil {
message := err.Error() + stderr.String()
logger.Error("error running command", "cmd", b.String(), "message", message, "error", err)
return "", errors.New(message)
}
if stderr.String() != "" {
logger.Error("error running command", "cmd", b.String(), "error", stderr.String())
return "", errors.New(stderr.String())
}

return stdout.String(), nil
return d.runCommands(commands)
}

// Query runs a query against the database. For Databases that are NOT in-memory.
Expand Down Expand Up @@ -239,6 +224,41 @@ func resultsToFrame(name string, res string, f *sdk.Frame, frames []*sdk.Frame)
return nil
}

func (d *DuckDB) runCommands(commands []string) (string, error) {
var stdout bytes.Buffer
var stderr bytes.Buffer

var b bytes.Buffer
b.Write([]byte(fmt.Sprintf(".mode %s %s", d.mode, newline)))
for _, c := range commands {
cmd := fmt.Sprintf("%s %s", c, newline)
b.Write([]byte(cmd))
}

var cmd *exec.Cmd
if d.docker {
volume := fmt.Sprintf("%s:%s", tempDir, tempDir)
cmd = exec.Command("docker", "run", "-i", "-v", volume, duckdbImage)
} else {
cmd = exec.Command(d.exe, d.Name)
}
cmd.Stdin = &b
cmd.Stdout = &stdout
cmd.Stderr = &stderr

err := cmd.Run()
if err != nil {
message := err.Error() + stderr.String()
logger.Error("error running command", "cmd", b.String(), "message", message, "error", err)
return "", errors.New(message)
}
if stderr.String() != "" {
logger.Error("error running command", "cmd", b.String(), "error", stderr.String())
return "", errors.New(stderr.String())
}
return stdout.String(), nil
}

// TODO

// func applyLabels(resultsFrame sdk.Frame, sourceFrames []*sdk.Frame) {
Expand Down
41 changes: 41 additions & 0 deletions duck/duckdb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,22 @@ func TestCommands(t *testing.T) {
assert.Contains(t, res, `[{"i":1,"j":5}]`)
}

func TestCommandsDocker(t *testing.T) {
db := NewInMemoryDB(Opts{Docker: true})

commands := []string{
"CREATE TABLE t1 (i INTEGER, j INTEGER);",
"INSERT INTO t1 VALUES (1, 5);",
"SELECT * from t1;",
}
res, err := db.RunCommands(commands)
if err != nil {
t.Fail()
return
}
assert.Contains(t, res, `[{"i":1,"j":5}]`)
}

func TestQuery(t *testing.T) {
db := NewDuckDB("foo")

Expand Down Expand Up @@ -149,6 +165,31 @@ func TestQueryFrameIntoFrame(t *testing.T) {
fmt.Printf("GOT: %s", txt)
}

func TestQueryFrameIntoFrameDocker(t *testing.T) {
db := NewInMemoryDB(Opts{Docker: true})

var values = []string{"2024-02-23 09:01:54"}
frame := data.NewFrame("foo", data.NewField("value", nil, values))
frame.RefID = "foo"

var values2 = []string{"2024-02-23 09:02:54"}
frame2 := data.NewFrame("foo", data.NewField("value", nil, values2))
frame2.RefID = "foo"

frames := []*data.Frame{frame, frame2}

model := &data.Frame{}
err := db.QueryFramesInto("foo", "select * from foo order by value desc", frames, model)
assert.Nil(t, err)

assert.Equal(t, 2, model.Rows())

txt, err := model.StringTable(-1, -1)
assert.Nil(t, err)

fmt.Printf("GOT: %s", txt)
}

func TestQueryFrameIntoFrameMultipleColumns(t *testing.T) {
db := NewInMemoryDB()

Expand Down
Loading