Merge pull request umami-software#51 from PabloSzx/loading_share_page

share page loading
scovik · Aug 22, 2020 · 05dc77c · 05dc77c
2 parents 8d27a0a + 0787818
commit 05dc77c
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/pages/share/[...id].js b/pages/share/[...id].js
@@ -6,6 +6,7 @@ import NotFound from 'pages/404';
 import { get } from 'lib/web';
 
 export default function SharePage() {
+  const [loading, setLoading] = useState(true);
   const [websiteId, setWebsiteId] = useState();
   const [notFound, setNotFound] = useState(false);
   const router = useRouter();
@@ -23,10 +24,16 @@ export default function SharePage() {
 
   useEffect(() => {
     if (id) {
-      loadData();
+      loadData().finally(() => {
+        setLoading(false);
+      });
+    } else {
+      setLoading(false);
     }
   }, [id]);
 
+  if (loading) return null;
+
   if (!id || notFound) {
     return <NotFound />;
   }