Skip to content

Commit

Permalink
h2: Reduce warnings about RST on invalid streams
Browse files Browse the repository at this point in the history
Per RFC 7540#6.4:

  However, after sending the RST_STREAM, the sending endpoint MUST be
  prepared to receive and process additional frames sent on the stream
  that might have been sent by the peer prior to the arrival of the
  RST_STREAM.
  • Loading branch information
klzgrad committed Oct 26, 2019
1 parent e1fe18e commit 75e5ff2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/net/spdy/spdy_session.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3044,7 +3044,7 @@ void SpdySession::OnRstStream(spdy::SpdyStreamId stream_id,
auto it = active_streams_.find(stream_id);
if (it == active_streams_.end()) {
// NOTE: it may just be that the stream was cancelled.
LOG(WARNING) << "Received RST for invalid stream" << stream_id;
VLOG(1) << "Received RST for invalid stream" << stream_id;
return;
}

Expand Down Expand Up @@ -3264,7 +3264,7 @@ void SpdySession::OnWindowUpdate(spdy::SpdyStreamId stream_id,

if (it == active_streams_.end()) {
// NOTE: it may just be that the stream was cancelled.
LOG(WARNING) << "Received WINDOW_UPDATE for invalid stream " << stream_id;
VLOG(1) << "Received WINDOW_UPDATE for invalid stream " << stream_id;
return;
}

Expand Down Expand Up @@ -3321,7 +3321,7 @@ void SpdySession::OnHeaders(spdy::SpdyStreamId stream_id,
auto it = active_streams_.find(stream_id);
if (it == active_streams_.end()) {
// NOTE: it may just be that the stream was cancelled.
LOG(WARNING) << "Received HEADERS for invalid stream " << stream_id;
VLOG(1) << "Received HEADERS for invalid stream " << stream_id;
return;
}

Expand Down

0 comments on commit 75e5ff2

Please sign in to comment.