Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about unsupported YAML features in gemfile: line in default.yml #865

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

pilaf
Copy link
Contributor

@pilaf pilaf commented Feb 17, 2025

Related to #863 and this comment:

Having a similar problem since we had this line in our .overcommit.yml:

gemfile: Gemfile # enforce bundled version of overcommit

And now overcommit doesn't strip out the inline comment, resulting in this weird looking error message:

Problem loading 'Gemfile # enforce bundled version of overcommit': /path/to/project/Gemfile # enforce bundled version of overcommit not found

I think adding support for comments in the gemfile: regexp is likely overkill and may still not be enough when the next person tries to use yet another YAML feature in that line, but perhaps this little warning would help someone else avoid tripping.

Add warning about unsupported YAML features in gemfile: line
@sds sds merged commit 9f142c2 into sds:main Feb 19, 2025
15 checks passed
@sds
Copy link
Owner

sds commented Feb 19, 2025

Thank you! Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants