introduce 'log_connection_messages' GUC setting #7
Conversation
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
2 times, most recently
from
355a9f6 to
471f295
Compare
src/backend/commands/variable.c
Outdated
|
|
||
| *extra = (void *) myextra; | ||
|
|
||
| if (log_connection_messages == NULL || log_connection_messages[0] == '\0') { |
There was a problem hiding this comment.
SplitIdentifierString already considers empty strings as ok, can't we get rid of this string?
There was a problem hiding this comment.
I've decided to keep it for now for the sake of being explicit in the code
|
+ tests should be extended to check the new GUC values, I guess |
yes, but let's wait with that untl the 1st round of feedback from the community |
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
from
471f295 to
7531ac9
Compare
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
2 times, most recently
from
0a20d43 to
2dca2c6
Compare
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
2 times, most recently
from
aea7a4c to
efafdb4
Compare
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
3 times, most recently
from
b85e0e4 to
4bf99bc
Compare
|
what's about https://github.com/sdudoladov/postgres/blob/make-logging-connections-fine-grained/src/backend/utils/misc/guc_tables.c#L90? |
| if (pg_strcasecmp(*newval, "all") == 0) | ||
| { | ||
| newlogconnect |= LOG_CONNECTION_ALL; | ||
| myextra = (int *) guc_malloc(ERROR, sizeof(int)); |
There was a problem hiding this comment.
shouldn't we check if myextra is NULL
obviously not. Thank you ! |
This patch removes 'log_connections' and 'log_disconnections' in favor of 'log_connection_messages', thereby introducing incompatibility Author: Sergey Dudoladov Reviewed-by: Justin Pryzby Discussion: https://www.postgresql.org/message-id/flat/CAA8Fd-qCB96uwfgMKrzfNs32mqqysi53yZFNVaRNJ6xDthZEgA%40mail.gmail.com
sdudoladov
force-pushed
the
make-logging-connections-fine-grained
branch
from
4bf99bc to
49a2ea5
Compare
this patch removes 'log_connections' and 'log_disconnections' in favor
of 'log_connection_messages', thereby introducing incompatibility
Author: Sergey Dudoladov
Reviewed-by:
Discussion:
https://www.postgresql.org/message-id/flat/CAA8Fd-qCB96uwfgMKrzfNs32mqqysi53yZFNVaRNJ6xDthZEgA%40mail.gmail.com