Skip to content

Commit

Permalink
fix: Align Etag Error Code With Freshness Documentation (aip-dev#837)
Browse files Browse the repository at this point in the history
  • Loading branch information
domgreen authored Feb 9, 2022
1 parent 57d5acf commit fab6a91
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion aip/general/0135.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ message DeleteBookRequest {
```

If the etag is provided and does not match the server-computed etag, the
request **must** fail with a `FAILED_PRECONDITION` error code.
request **must** fail with a `ABORTED` error code.

**Note:** Declarative-friendly resources (AIP-128) **must** provide the `etag`
field for Delete requests.
Expand Down Expand Up @@ -220,6 +220,7 @@ exist, the service **must** error with `NOT_FOUND` (HTTP 404) unless
[aip-131]: ./0131.md
[aip-132]: ./0132.md
[aip-136]: ./0136.md
[aip-154]: ./0154.md
[aip-203]: ./0203.md
[aip-214]: ./0214.md
[aip-216]: ./0216.md
Expand All @@ -232,6 +233,7 @@ exist, the service **must** error with `NOT_FOUND` (HTTP 404) unless

## Changelog

- **2022-02-02**: Changed eTag error from `FAILED_PRECONDITION` to `ABORTED` making it consistent with change to [AIP-154][] & [AIP-134][etag] on 2021-03-05.
- **2020-10-06**: Added guidance for declarative-friendly resources.
- **2020-10-06**: Added guidance for allowing no-op delete for missing
resources.
Expand Down

0 comments on commit fab6a91

Please sign in to comment.