E275 - Missing whitespace after keyword #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've applied some regex based replacements. Let's see if it smokes. |
Codecov Report
@@ Coverage Diff @@
## master #3711 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 296 296
Lines 67240 67240
=======================================
+ Hits 57905 57906 +1
+ Misses 9335 9334 -1
|
|
Thanks! What is the error message or the PEP number that this PR is fixing ?
It could be relevant to reflect it in the commit message
…Sent from my iPhone
On 6 Aug 2022, at 10:05, codecov[bot] ***@***.***> wrote:
Codecov Report
Merging #3711 (87543f1) into master (aa4f2ef) will increase coverage by 0.00%.
The diff coverage is 86.77%.
@@ Coverage Diff @@
## master #3711 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 296 296
Lines 67240 67240
=======================================
+ Hits 57905 57906 +1
+ Misses 9335 9334 -1
Impacted Files Coverage Δ
scapy/asn1/mib.py 90.72% <0.00%> (ø)
scapy/layers/http.py 77.29% <0.00%> (ø)
scapy/layers/ntlm.py 44.76% <0.00%> (ø)
scapy/layers/x509.py 91.99% <0.00%> (ø)
scapy/supersocket.py 60.36% <50.00%> (+0.30%) ⬆️
scapy/main.py 74.39% <60.00%> (ø)
scapy/arch/windows/structures.py 89.81% <66.66%> (ø)
scapy/contrib/pnio.py 83.76% <66.66%> (ø)
scapy/layers/inet6.py 88.23% <66.66%> (ø)
scapy/packet.py 82.65% <66.66%> (ø)
... and 25 more
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
|
E275
--
Viele Grüße
Nils Weiß
…On August 6, 2022 10:37:02 AM GMT+02:00, Guillaume Valadon ***@***.***> wrote:
Thanks! What is the error message or the PEP number that this PR is
fixing ?>
It could be relevant to reflect it in the commit message>
>
Sent from my iPhone>
>
> On 6 Aug 2022, at 10:05, codecov[bot] ***@***.***> wrote:>
> >
> Codecov Report>
> >
> Merging #3711 (87543f1) into master (aa4f2ef) will increase coverage
by 0.00%.>
> The diff coverage is 86.77%.>
> >
> @@ Coverage Diff @@>
> ## master #3711 +/- ##>
> =======================================>
> Coverage 86.11% 86.11% >
> =======================================>
> Files 296 296 >
> Lines 67240 67240 >
> =======================================>
> + Hits 57905 57906 +1 >
> + Misses 9335 9334 -1 >
> Impacted Files Coverage Δ >
> scapy/asn1/mib.py 90.72% <0.00%> (ø) >
> scapy/layers/http.py 77.29% <0.00%> (ø) >
> scapy/layers/ntlm.py 44.76% <0.00%> (ø) >
> scapy/layers/x509.py 91.99% <0.00%> (ø) >
> scapy/supersocket.py 60.36% <50.00%> (+0.30%) ⬆️>
> scapy/main.py 74.39% <60.00%> (ø) >
> scapy/arch/windows/structures.py 89.81% <66.66%> (ø) >
> scapy/contrib/pnio.py 83.76% <66.66%> (ø) >
> scapy/layers/inet6.py 88.23% <66.66%> (ø) >
> scapy/packet.py 82.65% <66.66%> (ø) >
> ... and 25 more >
> —>
> Reply to this email directly, view it on GitHub, or unsubscribe.>
> You are receiving this because you are subscribed to this thread.>
>
>
-- >
Reply to this email directly or view it on GitHub:>
#3711 (comment)>
You are receiving this because you authored the thread.>
>
Message ID: ***@***.***>
|
|
A good example if commit message for this kind of change is #1612
Could you also add the Co-Author-by to reflect the latest author of the line that this PR is modifying?
I know that this is a bit complicated but these as the rules that we defined in #1277
Thanks
…Sent from my iPhone
On 6 Aug 2022, at 11:19, Nils Weiss ***@***.***> wrote:
E275
--
Viele Grüße
Nils Weiß
On August 6, 2022 10:37:02 AM GMT+02:00, Guillaume Valadon ***@***.***> wrote:
>Thanks! What is the error message or the PEP number that this PR is
>fixing ?>
>It could be relevant to reflect it in the commit message>
>>
>Sent from my iPhone>
>>
>> On 6 Aug 2022, at 10:05, codecov[bot] ***@***.***> wrote:>
>> >
>> Codecov Report>
>> >
>> Merging #3711 (87543f1) into master (aa4f2ef) will increase coverage
>by 0.00%.>
>> The diff coverage is 86.77%.>
>> >
>> @@ Coverage Diff @@>
>> ## master #3711 +/- ##>
>> =======================================>
>> Coverage 86.11% 86.11% >
>> =======================================>
>> Files 296 296 >
>> Lines 67240 67240 >
>> =======================================>
>> + Hits 57905 57906 +1 >
>> + Misses 9335 9334 -1 >
>> Impacted Files Coverage Δ >
>> scapy/asn1/mib.py 90.72% <0.00%> (ø) >
>> scapy/layers/http.py 77.29% <0.00%> (ø) >
>> scapy/layers/ntlm.py 44.76% <0.00%> (ø) >
>> scapy/layers/x509.py 91.99% <0.00%> (ø) >
>> scapy/supersocket.py 60.36% <50.00%> (+0.30%) ⬆️>
>> scapy/main.py 74.39% <60.00%> (ø) >
>> scapy/arch/windows/structures.py 89.81% <66.66%> (ø) >
>> scapy/contrib/pnio.py 83.76% <66.66%> (ø) >
>> scapy/layers/inet6.py 88.23% <66.66%> (ø) >
>> scapy/packet.py 82.65% <66.66%> (ø) >
>> ... and 25 more >
>> —>
>> Reply to this email directly, view it on GitHub, or unsubscribe.>
>> You are receiving this because you are subscribed to this thread.>
>>
>>
>-- >
>Reply to this email directly or view it on GitHub:>
>#3711 (comment)>
>You are receiving this because you authored the thread.>
>>
>Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
|
|
Phuu .. do you have a handy git blame command to obtain that information?
--
Viele Grüße
Nils Weiß
…On August 6, 2022 12:04:33 PM GMT+02:00, Guillaume Valadon ***@***.***> wrote:
A good example if commit message for this kind of change is
#1612>
>
Could you also add the Co-Author-by to reflect the latest author of the
line that this PR is modifying?>
>
I know that this is a bit complicated but these as the rules that we
defined in #1277>
>
Thanks >
>
Sent from my iPhone>
>
> On 6 Aug 2022, at 11:19, Nils Weiss ***@***.***> wrote:>
> >
> >
> E275>
> -- >
> Viele Grüße>
> >
> Nils Weiß>
> >
> On August 6, 2022 10:37:02 AM GMT+02:00, Guillaume Valadon
***@***.***> wrote:>
> >Thanks! What is the error message or the PEP number that this PR is>
> >fixing ?>>
> >It could be relevant to reflect it in the commit message>>
> >>>
> >Sent from my iPhone>>
> >>>
> >> On 6 Aug 2022, at 10:05, codecov[bot] ***@***.***> wrote:>>
> >> >>
> >> Codecov Report>>
> >> >>
> >> Merging #3711 (87543f1) into master (aa4f2ef) will increase
coverage>
> >by 0.00%.>>
> >> The diff coverage is 86.77%.>>
> >> >>
> >> @@ Coverage Diff @@>>
> >> ## master #3711 +/- ##>>
> >> =======================================>>
> >> Coverage 86.11% 86.11% >>
> >> =======================================>>
> >> Files 296 296 >>
> >> Lines 67240 67240 >>
> >> =======================================>>
> >> + Hits 57905 57906 +1 >>
> >> + Misses 9335 9334 -1 >>
> >> Impacted Files Coverage Δ >>
> >> scapy/asn1/mib.py 90.72% <0.00%> (ø) >>
> >> scapy/layers/http.py 77.29% <0.00%> (ø) >>
> >> scapy/layers/ntlm.py 44.76% <0.00%> (ø) >>
> >> scapy/layers/x509.py 91.99% <0.00%> (ø) >>
> >> scapy/supersocket.py 60.36% <50.00%> (+0.30%) ⬆️>>
> >> scapy/main.py 74.39% <60.00%> (ø) >>
> >> scapy/arch/windows/structures.py 89.81% <66.66%> (ø) >>
> >> scapy/contrib/pnio.py 83.76% <66.66%> (ø) >>
> >> scapy/layers/inet6.py 88.23% <66.66%> (ø) >>
> >> scapy/packet.py 82.65% <66.66%> (ø) >>
> >> ... and 25 more >>
> >> —>>
> >> Reply to this email directly, view it on GitHub, or unsubscribe.>>
> >> You are receiving this because you are subscribed to this
thread.>>
> >>>
> >>>
> >-- >>
> >Reply to this email directly or view it on GitHub:>>
> >#3711 (comment)>>
> >You are receiving this because you authored the thread.>>
> >>>
> >Message ID: ***@***.***>>
> —>
> Reply to this email directly, view it on GitHub, or unsubscribe.>
> You are receiving this because you commented.>
>
>
-- >
Reply to this email directly or view it on GitHub:>
#3711 (comment)>
You are receiving this because you authored the thread.>
>
Message ID: ***@***.***>
|
Co-authored-by: Alexander Aring <[email protected]> Co-authored-by: Anmol Sarma <[email protected]> Co-authored-by: antoine.torre <[email protected]> Co-authored-by: Antoine Vacher <[email protected]> Co-authored-by: Arnaud Ebalard <[email protected]> Co-authored-by: atlowl <[email protected]> Co-authored-by: Brian Bienvenu <[email protected]> Co-authored-by: Chris Packham <[email protected]> Co-authored-by: CQ <[email protected]> Co-authored-by: Daniel Collins <[email protected]> Co-authored-by: Federico Maggi <[email protected]> Co-authored-by: Florian Maury <[email protected]> Co-authored-by: _Frky <[email protected]> Co-authored-by: g-mahieux <[email protected]> Co-authored-by: gpotter2 <[email protected]> Co-authored-by: Guillaume Valadon <[email protected]> Co-authored-by: Hao Zheng <[email protected]> Co-authored-by: Haresh Khandelwal <[email protected]> Co-authored-by: Harri Hämäläinen <[email protected]> Co-authored-by: hecke <[email protected]> Co-authored-by: Jan Romann <[email protected]> Co-authored-by: Jan Sebechlebsky <[email protected]> Co-authored-by: jdiog0 <[email protected]> Co-authored-by: jockque <[email protected]> Co-authored-by: Julien Bedel <[email protected]> Co-authored-by: Keith Scott <[email protected]> Co-authored-by: Kfir Gollan <[email protected]> Co-authored-by: Lars Munch <[email protected]> Co-authored-by: ldp77 <[email protected]> Co-authored-by: Leonard Crestez <[email protected]> Co-authored-by: Marcel Patzlaff <[email protected]> Co-authored-by: Martijn Thé <[email protected]> Co-authored-by: Martine Lenders <[email protected]> Co-authored-by: Michael Farrell <[email protected]> Co-authored-by: Michał Mirosław <[email protected]> Co-authored-by: mkaliszan <[email protected]> Co-authored-by: mtury <[email protected]> Co-authored-by: Neale Ranns <[email protected]> Co-authored-by: Octavian Toader <[email protected]> Co-authored-by: Peter Eisenlohr <[email protected]> Co-authored-by: Phil <[email protected]> Co-authored-by: Pierre Lalet <[email protected]> Co-authored-by: Pierre Lorinquer <[email protected]> Co-authored-by: piersoh <[email protected]> Co-authored-by: plorinquer <[email protected]> Co-authored-by: pvinci <[email protected]> Co-authored-by: Rahul Jadhav <[email protected]> Co-authored-by: Robin Jarry <[email protected]> Co-authored-by: romain-perez <[email protected]> Co-authored-by: rperez <rperez@debian> Co-authored-by: Sabrina Dubroca <[email protected]> Co-authored-by: Sebastian Baar <[email protected]> Co-authored-by: sebastien mainand <[email protected]> Co-authored-by: smehner1 <[email protected]> Co-authored-by: speakinghedge <[email protected]> Co-authored-by: Steven Van Acker <[email protected]> Co-authored-by: Thomas Faivre <[email protected]> Co-authored-by: Tran Tien Dat <[email protected]> Co-authored-by: Wael Mahlous <[email protected]> Co-authored-by: waeva <[email protected]>
|
Added all the Co-Authors |
polybassa
changed the title
|
I usually do: |
guedou
approved these changes
Aug 7, 2022
|
Thanks. Good to know for next time
--
Viele Grüße
Nils Weiß
…On August 7, 2022 6:07:48 PM GMT+02:00, Guillaume Valadon ***@***.***> wrote:
I usually do:
```
flake8 --select=E20 scapy/ > lines.txt
bash pepin.sh > co-authored-by.txt
```
[pepin.sh.txt](https://github.com/secdev/scapy/files/9277110/pepin.sh.txt)
--
Reply to this email directly or view it on GitHub:
#3711 (comment)
You are receiving this because you modified the open/close state.
Message ID: ***@***.***>
|
gpotter2
approved these changes
Aug 10, 2022
|
Thanks a lot for doing this polybassa ! |
|
You are welcome. Thanks to my IDE for search and replace ;-)
…On August 10, 2022 6:08:18 PM GMT+02:00, gpotter2 ***@***.***> wrote:
Thanks a lot for doing this polybassa !
--
Reply to this email directly or view it on GitHub:
#3711 (comment)
You are receiving this because you modified the open/close state.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.