Fixes learned from a bad deploy

segiddins · Jun 25, 2014 · a91ef5f · a91ef5f
1 parent 96aa676
commit a91ef5f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/db/migrate/20140617214701_add_success_email.rb b/db/migrate/20140617214701_add_success_email.rb
@@ -4,11 +4,17 @@ def change
     add_column :repositories, :send_build_success_email, :boolean, :default => true, :null => false
     reversible do |dir|
       change_table :builds do |t|
-        dir.up { t.change :build_failure_email_sent, :boolean, :default => false, :null => false }
+        dir.up do
+          execute 'UPDATE builds SET build_failure_email_sent = 0 WHERE build_failure_email_sent IS NULL'
+          t.change :build_failure_email_sent, :boolean, :default => false, :null => false
+        end
         dir.down { t.change :build_failure_email_sent, :boolean, :default => nil, :null => true }
       end
       change_table :repositories do |t|
-        dir.up { t.change :send_build_failure_email, :boolean, :default => true, :null => false }
+        dir.up do
+          execute 'UPDATE repositories SET send_build_failure_email = 1 WHERE send_build_failure_email IS NULL'
+          t.change :send_build_failure_email, :boolean, :default => true, :null => false
+        end
         dir.down { t.change :send_build_failure_email, :boolean, :default => true, :null => true }
       end
     end

diff --git a/lib/git_blame.rb b/lib/git_blame.rb
@@ -78,7 +78,7 @@ def last_git_name_and_email_in_branch(build)
     end
 
     def lookup_git_names_and_emails(git_names_and_emails)
-      git_names_and_emails.map do |git_name_and_email|
+      Array(git_names_and_emails).map do |git_name_and_email|
         name, email = git_name_and_email.split(":")
         Array(email_from_git_email(email))
       end.flatten.compact.uniq