hw/core: Add missing return on error

If dies is not supported by this machine's CPU topology, don't keep processing options and return directly. Fixes: 0aebebb ("machine: reject -smp dies!=1 for non-PC machines") Signed-off-by: Philippe Mathieu-Daudé <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
sekmet · Aug 13, 2021 · 0b46318 · 0b46318
1 parent 24d84c7
commit 0b46318
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/hw/core/machine.c b/hw/core/machine.c
@@ -752,6 +752,7 @@ static void smp_parse(MachineState *ms, SMPConfiguration *config, Error **errp)
 
     if (config->has_dies && config->dies != 0 && config->dies != 1) {
         error_setg(errp, "dies not supported by this machine's CPU topology");
+        return;
     }
 
     /* compute missing values, prefer sockets over cores over threads */