Skip to content

Commit

Permalink
kv/RocksdbStore: remove perfcounter l_rocksdb_gets.
Browse files Browse the repository at this point in the history
Perfcounter l_rocksdb_get_latency contain l_rocksdb_gets.

Signed-off-by: Jianpeng Ma <[email protected]>
  • Loading branch information
majianpeng committed Aug 20, 2020
1 parent aa6fca2 commit 2a4e96b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions src/kv/RocksDBStore.cc
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,6 @@ int RocksDBStore::do_open(ostream &out,
ceph_assert(default_cf != nullptr);

PerfCountersBuilder plb(cct, "rocksdb", l_rocksdb_first, l_rocksdb_last);
plb.add_u64_counter(l_rocksdb_gets, "get", "Gets");
plb.add_time_avg(l_rocksdb_get_latency, "get_latency", "Get latency");
plb.add_time_avg(l_rocksdb_submit_latency, "submit_latency", "Submit Latency");
plb.add_time_avg(l_rocksdb_submit_sync_latency, "submit_sync_latency", "Submit Sync Latency");
Expand Down Expand Up @@ -1580,7 +1579,6 @@ int RocksDBStore::get(
}
}
utime_t lat = ceph_clock_now() - start;
logger->inc(l_rocksdb_gets);
logger->tinc(l_rocksdb_get_latency, lat);
return 0;
}
Expand Down Expand Up @@ -1616,7 +1614,6 @@ int RocksDBStore::get(
ceph_abort_msg(s.getState());
}
utime_t lat = ceph_clock_now() - start;
logger->inc(l_rocksdb_gets);
logger->tinc(l_rocksdb_get_latency, lat);
return r;
}
Expand Down Expand Up @@ -1654,7 +1651,6 @@ int RocksDBStore::get(
ceph_abort_msg(s.getState());
}
utime_t lat = ceph_clock_now() - start;
logger->inc(l_rocksdb_gets);
logger->tinc(l_rocksdb_get_latency, lat);
return r;
}
Expand Down
1 change: 0 additions & 1 deletion src/kv/RocksDBStore.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

enum {
l_rocksdb_first = 34300,
l_rocksdb_gets,
l_rocksdb_get_latency,
l_rocksdb_submit_latency,
l_rocksdb_submit_sync_latency,
Expand Down

0 comments on commit 2a4e96b

Please sign in to comment.