Skip to content

Commit

Permalink
osd, bluestore: Display current size of osd_max_object_size
Browse files Browse the repository at this point in the history
It is better to show current value than showing same value twice.

Signed-off-by: Shinobu Kinjo <[email protected]>
  • Loading branch information
shinobu-x committed Dec 30, 2017
1 parent 24bc418 commit 88080ce
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 5 additions & 3 deletions src/os/bluestore/BlueStore.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4013,9 +4013,11 @@ int BlueStore::get_block_device_fsid(CephContext* cct, const string& path,
int BlueStore::_open_path()
{
// sanity check(s)
if (cct->_conf->get_val<uint64_t>("osd_max_object_size") >=
4*1024*1024*1024ull) {
derr << __func__ << " osd_max_object_size >= 4GB; BlueStore has hard limit of 4GB." << dendl;
auto osd_max_object_size =
cct->_conf->get_val<uint64_t>("osd_max_object_size");
if (osd_max_object_size >= 4*1024*1024*1024ull) {
derr << __func__ << " osd_max_object_size: " << osd_max_object_size
<< "; BlueStore has hard limit of 4GB." << dendl;
return -EINVAL;
}
assert(path_fd < 0);
Expand Down
4 changes: 2 additions & 2 deletions src/osd/PrimaryLogPG.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4580,8 +4580,8 @@ static int check_offset_and_length(uint64_t offset, uint64_t length,
length > max ||
offset + length > max) {
ldpp_dout(dpp, 10) << __func__ << " "
<< "osd_max_object_size >= 4GB; Hard limit of object size is 4GB.\n"
<< dendl;
<< "osd_max_object_size: " << max
<< "; Hard limit of object size is 4GB." << dendl;
return -EFBIG;
}

Expand Down

0 comments on commit 88080ce

Please sign in to comment.