Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits #18

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Minor edits #18

merged 3 commits into from
Sep 11, 2024

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • coffee_calc function renamed to calc_coffee

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (de07b30) to head (a2d156e).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           61        62    +1     
  Branches        13        13           
=========================================
+ Hits            61        62    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sepandhaghighi sepandhaghighi added enhancement New feature or request refactoring labels Sep 8, 2024
@sepandhaghighi sepandhaghighi added this to the mycoffee v0.2 milestone Sep 8, 2024
@sepandhaghighi sepandhaghighi marked this pull request as ready for review September 8, 2024 23:30
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadrasabouri sadrasabouri merged commit cf0e5f2 into dev Sep 11, 2024
48 checks passed
@sadrasabouri sadrasabouri deleted the minor_edits branch September 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants