Simplify implementation of #[serde(default=...)] #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm @homu r+ |
homu
added a commit
that referenced
this pull request
Jun 10, 2016
Simplify implementation of #[serde(default=...)]
| /// The default is given by `std::default::Default::default()`. | ||
| Default, | ||
| /// The default is given by this function. | ||
| Path(ast::Path), |
There was a problem hiding this comment.
It would be also great to support literals and constants as well as functions, so you can actually write
#[serde(default="0.1")]
pub field: f32,
There was a problem hiding this comment.
The only situation that would be problematic is when the field is of function type, but I don't think we can do anything useful there anyway.
There was a problem hiding this comment.
I filed #368 to track your idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.