Updated to NET8, Added Unit Tests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `serilog-enrichers-memory` solution to support Visual Studio 2022 and introduces a new test project to enhance code quality and maintainability. Key changes include: - Upgraded the solution file to Visual Studio 2022 and added a new test project (`Serilog.Enrichers.Memory.Tests`) with a "tests" solution folder and a "Solution Items" folder for better organization. - Updated copyright year in `MemoryUsageEnricher.cs` to 2024 and refactored the file using the latest C# syntax, including file-scoped namespaces and target-typed `new` expressions. Improved documentation comments and aligned the namespace declaration with ReSharper's recommendations. - Introduced a new static class `ProcessLoggerConfigurationExtensions` providing an extension method `WithMemoryUsage` to enrich log events with memory usage information, leveraging the latest C# syntax for cleaner method chaining. - Updated the main project file to target .NET 8.0, upgraded the Serilog dependency to version 4.0.0, and updated the package version to 1.1.0 to reflect new features and improvements. - Added unit tests for `MemoryUsageEnricher` and `ProcessLoggerConfigurationExtensions` in new test files, ensuring correct functionality and error handling. - Created a new test project file targeting .NET 8.0 with modern project settings, including implicit usings and nullable reference types, and added necessary package references for xUnit, Moq, and Serilog testing.
Removed the "Solution Items" project from the solution to streamline project structure and focus on specific project-related files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
serilog-enrichers-memorysolution to support Visual Studio 2022 and introduces a new test project to enhance code quality and maintainability. Key changes include:Serilog.Enrichers.Memory.Tests) with a "tests" solution folder and a "Solution Items" folder for better organization.MemoryUsageEnricher.csto 2024 and refactored the file using the latest C# syntax, including file-scoped namespaces and target-typednewexpressions. Improved documentation comments and aligned the namespace declaration with ReSharper's recommendations.ProcessLoggerConfigurationExtensionsproviding an extension methodWithMemoryUsageto enrich log events with memory usage information, leveraging the latest C# syntax for cleaner method chaining.MemoryUsageEnricherandProcessLoggerConfigurationExtensionsin new test files, ensuring correct functionality and error handling.