Spec-align resolving history handling during navigation #34747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thank you! That's a lot of failures I wasn't expecting, I'm taking a look 👀 |
…tion Makes use of the is_initial_about_blank property on Document in order to determine whether the navigation should create a history entry, or replace the current history entry. Signed-off-by: Shane Handley <[email protected]>
shanehandley
force-pushed
the
navigation-history-handling
branch
from
41d7a42 to
02b8e4e
Compare
|
I've pushed a fix - I suspect I thought it was passing all tests becuase I confused it with another task 😬 sorry about that. Here's an updated try: https://github.com/shanehandley/servo/actions/runs/12475391448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of the
is_initial_about_blankproperty onDocumentin order to determine whether a navigation should create a history entry, or replace the current history entry.This unfortunately introduces a new intermittent failure (
/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html, example). Initially I thought I should not push the change and open this PR, but it appears to belong in the family of intermittents that Gregory was looking into in #31973 and a little more spec alignment might be useful - but happy to close this if it's an issue.Try
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors