[Feature] Function Tooling #2544
Open
+327
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tushar-ml
requested review from
merrymercy,
Ying1123,
hnyls2002,
zhyncs,
ispobock and
ByronHsu
as code owners
HaoyuWang4188
added a commit
to HaoyuWang4188/sglang
that referenced
this pull request
Dec 25, 2024
| "message": {"role": "assistant", "content": ret_item["text"]}, | ||
| "message": { | ||
| "role": "assistant", | ||
| "content": ret_item["text"], |
There was a problem hiding this comment.
Maybe we can set content to be "content": null just like the official OpenAI API Reference?
|
Based on the communication in Slack, I have left some of my review comments. 😄 |
Co-authored-by: Haoyu Wang <[email protected]>
Co-authored-by: Haoyu Wang <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR provides support for function calling #2429 . Currently function tooling implemented for tokenizer apply_chat_template. Streaming not support as well for function tooling.
Modifications
Checklist