Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update_weights_from_disk endpoint to Engine #4102

Conversation

jhinpan
Copy link
Collaborator

@jhinpan jhinpan commented Mar 5, 2025

Motivation

Motivated by GRPO in TRL: trying to use update_weights_from_disk in offline engine mode for GRPO Training

Modifications

  • Mainly add the update_weights_from_disk function in the engine.py just like update_weights_from_tensor and also update_weights_from_distributed
  • Also add a unit test only for testing update_weights_from_disk in the offline engine mode

Checklist

Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge test_engine_update_weights.py with test_update_weights.py. Like the style of test_update_weights_from_dist.py.

Also, whenever you add new tests, modify the run_suites.

@zhaochenyang20 zhaochenyang20 merged commit 70b3c6e into sgl-project:main Mar 5, 2025
3 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants