-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower varying parameters as pointers instead of SSA values. #5919
Open
csyonghe
wants to merge
19
commits into
shader-slang:master
Choose a base branch
from
csyonghe:spirv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+948
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buteAtCentroid etc. to be implemented correctly.
csyonghe
changed the title
Add executable test on matrix-typed vertex input.
Lower varying parameters as pointers instead of SSA values.
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we lower entry point varying parameters so that they are emitted as a
ConstRef<T>
typed pointer value instead of a SSA value.This is required to properly implement things like
GetAttributeAtVertex
orEvaluateAttributeAtCentroid
, where the argument is expected to be a reference to a vertex attribute declaration.Previously this is implemented as a hack assuming the
x
inGetAttributeAtVertex(x)
is aload(attribute_var)
, which isn't safe or correct.By lowering all varying parameters as pointers, we can properly implement
GetAttributeAtVertex(x)
assumingx
is a pointer in theInput
address space.This also allowed us to support using types that needs storage lowering for vertex attributes, such as column_major matrix types or bool types, by reusing the existing
lowerBufferElementTypeToStorageType
pass, which requires any such type to be used via a buffer or a pointer. This lowering is required to supportOptional<T>
in vertex attributes.