Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions/upload-artifact from v3 to v4 #6051

Conversation

jkwak-work
Copy link
Collaborator

The version 3 of actions/upload-artifact will be deprecated soon. https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

This commit upgrades to v4.
There is a document describing how to migrate/upgrade: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

The breaking change on v4 is that the uploaded files are immutable and we can no longer append files with the same name. We don't seem to be doing it so it should be fine for us.

Closes #6050

The version 3 of actions/upload-artifact will be deprecated soon.
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

This commit upgrades to v4.
There is a document describing how to migrate/upgrade:
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

The breaking change on v4 is that the uploaded files are immutable and
we can no longer append files with the same name. We don't seem to be
doing it so it should be fine for us.

Closes shader-slang#6050
@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Jan 9, 2025
@jkwak-work jkwak-work self-assigned this Jan 9, 2025
@jkwak-work jkwak-work requested a review from a team as a code owner January 9, 2025 22:30
@jkwak-work jkwak-work requested a review from expipiplus1 January 9, 2025 22:33
@jkwak-work jkwak-work enabled auto-merge (squash) January 9, 2025 22:51
@jkwak-work jkwak-work merged commit b72e62f into shader-slang:master Jan 9, 2025
17 checks passed
@jkwak-work jkwak-work deleted the fix/update_github_action_upload_artifact_version_from_3_to_4 branch January 9, 2025 23:16
juliusikkala pushed a commit to juliusikkala/slang that referenced this pull request Jan 12, 2025
The version 3 of actions/upload-artifact will be deprecated soon.
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

This commit upgrades to v4.
There is a document describing how to migrate/upgrade:
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

The breaking change on v4 is that the uploaded files are immutable and
we can no longer append files with the same name. We don't seem to be
doing it so it should be fine for us.

Closes shader-slang#6050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade github/actions/upload-artifact and download-artifact to version 4
2 participants